Closed Bug 1368587 Opened 7 years ago Closed 7 years ago

TabManager.removeDelegate does not actually remove a delegate

Categories

(Firefox for iOS :: Browser, enhancement, P1)

Product:
Firefox for iOS
Component:
Browser
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Iteration:
1.23

People

(Reporter: farhan, Assigned: farhan)

Details

(Whiteboard: [MobileCore])

Attachments

(1 file)

Pull Request
55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review 
TabManager.removeDelegate removes a WeakTabManagerDelegate by comparing by reference. But if the reference has been deinited then the comparison fails and the WeakTabManagerDelegate is never removed.
Attached file Pull Request — 

        Attachment #8872478 -
        Flags: review?(sleroux)

        Attachment #8872478 -
        Flags: review?(sleroux) → review+

    
    

    
  
master https://github.com/mozilla-mobile/firefox-ios/commit/349d26207730f902a6100113597746521e4dcee7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [MobileCore] → [MobileCore][needsuplift]
Whiteboard: [MobileCore][needsuplift] → [MobileCore]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: