Closed Bug 1368594 Opened 7 years ago Closed 7 years ago

Favicons for a site fail to load when a single icon from the site fails

Categories

(Firefox for iOS :: Browser, enhancement, P1)

Product:
Firefox for iOS
Component:
Browser
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Iteration:
1.23

People

(Reporter: farhan, Assigned: farhan)

Details

(Whiteboard: [mobileAS])

Attachments

(1 file)

Pull Request
55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review 
When going to http://earnesticecream.com you'll notice that no favicons are loaded for this url. But looking at the metadata for this page there are 8 favicons available. 


The first one of the 8 results in a 404 and because of that the rest of them never actually load. 

Even if one of the favicons is bad we should be able to use one of the other favicons to show a valid icon. 

PS: If you are in Vancouver sometime. Be sure to try some Earnest!
Attached file Pull Request — 

        Attachment #8872492 -
        Flags: review?(sleroux)

        Attachment #8872492 -
        Flags: review?(sleroux) → review+

    
    

    
  
master https://github.com/mozilla-mobile/firefox-ios/commit/e6864047f10fe50fd2e5bc0f96955cefa161c043
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [mobileAS] → [mobileAS][needsuplift]
Whiteboard: [mobileAS][needsuplift] → [mobileAS]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: