1368596 - Add telemetry to track number of deprecated configurations passed to navigator.requestMediaKeySystemAccess

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

In bug 1355252 I'm trying to remove support for some deprecated EME APIs. This change would make our implementation stricter, and so we'd reject some requests to access EME that today would be granted. So I'd like telemetry to track how often we'd reject requests that would otherwise succeed if we make the changes in bug 1355252.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess().

Review commit: https://reviewboard.mozilla.org/r/144052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144052/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8872508 [details]
Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess().

https://reviewboard.mozilla.org/r/144052/#review147730

r+, assuming the answer is "no" below:

::: dom/media/eme/MediaKeySystemAccessManager.cpp:206
(Diff revision 1)
> +    if (warnings.Get("MediaEMENoCapabilitiesDeprecatedWarning")) {
> +      Telemetry::Accumulate(
> +        Telemetry::HistogramID::MEDIA_EME_REQUEST_DEPRECATED_WARNINGS, 1);
> +      EME_LOG("MEDIA_EME_REQUEST_DEPRECATED_WARNINGS "
> +              "MediaEMENoCapabilitiesDeprecatedWarning");
> +    } else if (warnings.Get("MediaEMENoCodecsDeprecatedWarning")) {

`else if` -- can't have both at the same time?

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8872508 [details]
Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess().

https://reviewboard.mozilla.org/r/144052/#review147730

> `else if` -- can't have both at the same time?

We can't have both at the same time. The "codecs" check happens on a MediaKeySystemCapability's contentType attribute, but if there's no MediaKeySystemCapability (which is what the first warning checks) then there's no contentType to check.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b29929108b33

Comment 5

[François Marier [:francois]]

Comment on attachment 8872508 [details]
Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess().

https://reviewboard.mozilla.org/r/144052/#review147914

datareview+

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=587dd0b6c84e

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33c7495a708fc89bc8e730daab1b13b4b93b605e
Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess(). r=gerald,r=francois

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33c7495a708f