1368988 - store-failure-lines "UnboundLocalError: local variable 'failure_lines' referenced before assignment"

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect, P1)

Description

[Ed Morley [:emorley]]

James, could you take a look?

https://rpm.newrelic.com/accounts/677903/applications/14179757/filterable_errors?tw%5Bend%5D=1496229073&tw%5Bstart%5D=1495624273#/show/95ef8417-41d3-11e7-931c-0242ac110012_0_4802/stack_trace?top_facet=transactionUiName&primary_facet=error.class&barchart=barchart&_k=nm1xtq

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:failure_line_error > mozilla:master

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0fc556cc647b2493d99d9c806fdf2330315345f4
Bug 1368988 - OperationalError ignored during failure_line storage.

This code assumes that any caught error results in a retry. But
that isn't actaully true for OperationalError where we only want
to retry if it's a specific kind of error, and otherwise just raise.

Comment 3

[Ed Morley [:emorley]]

Many thanks for sorting this so quickly!