1369585 - Explicitly show the row / column in grid cell infobar

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Micah Tigley [:micah]]

We need to be clear about the row / column of a grid cell in the infobar. Instead of just displaying the row/ column numbers, we will show : `Row: ${rowNumber} / Column: ${colNumber}`

Comment 1

[Micah Tigley [:micah]]

Attachment: Bug 1369585 - Explicitly identify the row and columns in cell infobar.

Review commit: https://reviewboard.mozilla.org/r/145536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145536/

Comment 2

[Micah Tigley [:micah]]

Comment on attachment 8874073 [details]
Bug 1369585 - Explicitly identify the row and columns in cell infobar.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145536/diff/1-2/

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e9c3d9dd68e
Explicitly identify the row and columns in cell infobar. r=gl

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8874073 [details]
Bug 1369585 - Explicitly identify the row and columns in cell infobar.

https://reviewboard.mozilla.org/r/145536/#review149526

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5e9c3d9dd68e

Comment 6

[Ton [:Tonnes]]

> +layout.rowColumnPositions=Row %S \/ Column %S

This change is causing an error on the L10n dashboard:

"unknown escape sequence, \/ at line 48, column 34 for layout.rowColumnPositions"

How about using either only / or a dash here, or perhaps "Row %S, Column %S" to match a nearly similar string (console.properties:errLineCol)?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ee2e37e9452
Remove L10n unknown escape sequence for layout.rowColumnPositions. r=me

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

Landed a fix.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Gabriel [:gl] (ΦωΦ) from comment #8)
> Landed a fix.

Thanks!

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4ee2e37e9452