Closed
Bug 1369586
Opened 7 years ago
Closed 7 years ago
Give grid area name text a background and rounded border
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: micah, Assigned: micah)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
4.83 KB,
patch
|
gl
:
review+
|
Details | Diff | Splinter Review |
We want to give area name text displayed in the grid area overlay a white background and a rounded border so that the text is easier to identify.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → tigleym
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•7 years ago
|
Priority: -- → P3
| Comment hidden (mozreview-request) |
|
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874072 [details] Bug 1369586 - Use new colours for the grid cell and area fills. https://reviewboard.mozilla.org/r/145532/#review149810
Attachment #8874072 -
Flags: review?(gl) → review+
|
|
||
Comment 3•7 years ago
|
||
Attachment #8874072 -
Attachment is obsolete: true
Attachment #8874509 -
Flags: review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/60bbd8e76c33 Add a border around the grid area name overlay. r=gl
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a312474c646c Fix eslint error with 'currentZoom' variable never being used in css-grid.js. r=me
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/60bbd8e76c33 https://hg.mozilla.org/mozilla-central/rev/a312474c646c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
|
Assignee | |
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874072 [details] Bug 1369586 - Use new colours for the grid cell and area fills. https://reviewboard.mozilla.org/r/145532/#review151602 Landed
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•