Closed
Bug 1369713
Opened 7 years ago
Closed 7 years ago
Solaris gcc build of xptcall wrongly expects xptcstubsdef_asm.solx86
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: petr.sumbera, Assigned: petr.sumbera)
Details
Attachments
(1 file)
1.51 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 Build ID: 20170518000419 Steps to reproduce: 127:16.87 xpcshell 127:24.74 gmake[5]: *** No rule to make target 'xptcstubsdef_asm.solx86', needed by 'misc'. Stop. 127:24.74 gmake[4]: *** [/var/tmp/firefox/config/recurse.mk:100: xpcom/reflect/xptcall/md/unix/misc] Error 2 xptcstubsdef_asm.solx86 is generated just when gcc is not used
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8873819 -
Flags: review?(mh+mozilla)
Updated•7 years ago
|
Component: Untriaged → Build Config
Product: Firefox → Core
Comment 2•7 years ago
|
||
Comment on attachment 8873819 [details] [diff] [review] Bug1369713.patch Review of attachment 8873819 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/reflect/xptcall/md/unix/moz.build @@ +59,5 @@ > 'xptcinvoke_x86_64_unix.cpp', > 'xptcstubs_x86_64_linux.cpp' > ] > else: > + GENERATED_FILES = [ You might as well remove the parts that are not GNU_CC, since we don't support building with something other than GCC/Clang on Solaris (CONFIG['GNU_CC'] is true for clang too)
Attachment #8873819 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•7 years ago
|
||
I would prefer not to remove it now. I would have to remove also those unused files then. And it's not so long after we tried to use Studio compiler.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Updated•7 years ago
|
Assignee: nobody → petr.sumbera
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0c16110ecba6 Solaris gcc build of xptcall wrongly expects xptcstubsdef_asm.solx86. r=glandium
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0c16110ecba6
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•