1369828 - Intermittent stylo native-theme/492155-4.html == native-theme/492155-4.html | image comparison, max difference: 1, number of differing pixels: 1

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=104135478&repo=autoland

https://queue.taskcluster.net/v1/task/blEudiCtREmPZZYELplRfA/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/blEudiCtREmPZZYELplRfA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

This started frequently failing on Stylo builds when bug 1367488 landed on autoland.

Comment 1

[Botond Ballo [:botond]]

The failure is caused by a single color value difference of a single pixel at the edge of a scrollbar thumb. This is a benign difference that's consistent with e.g. the thumb being layerized in one image, and not in the other, and could plausibly have been caused by bug 1367488 since it potentially changes the visible region and clip rect on a thumb layer.

Since the difference is benign, it should be appropriate to fuzz it away. However, I'm not sure where to insert a fuzzing annotation in this case, since the comparison being done in the failing test (492155-4.html == 492155-4.html) does not match what is in reftest.list (492155-4.html != about:blank). I assume there is something Stylo-specific going on here (like the page rendered with Stylo is being compared to the page rendered without Stylo), but I'm not sure whether to insert a fuzzing annotation in such a situation.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

the fuzzy condition in this case would be fuzzy-if(styloVsGecko,1,1)

Comment 3

[Kartikaya Gupta (email:[e-mail])]

or even better, fuzzy-if(styloVsGecko,0-1,0-1) since it seems to be intermittent

:)

Comment 4

[Botond Ballo [:botond]]

Thanks, Kats!

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1369828 - Fuzz native-theme/492155-4.html during stylo-vs-gecko comparison.

Review commit: https://reviewboard.mozilla.org/r/145452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145452/

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8874001 [details]
Bug 1369828 - Fuzz native-theme/492155-4.html during stylo-vs-gecko comparison.

https://reviewboard.mozilla.org/r/145452/#review149376

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Went ahead and triggered autoland for this so I can get it included in my merge of autoland to mozilla-central tonight.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60b41398d6c2
Fuzz native-theme/492155-4.html during stylo-vs-gecko comparison. r=mstange

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/43039280fe46
Fuzz native-theme/492155-4.html during stylo-vs-gecko comparison. r=mstange a=bustage

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/43039280fe46

Comment 11

[Intermittent Failures Robot]

71 failures in 149 pushes (0.477 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 71

Platform breakdown:
* linux64-stylo: 52
* linux64-stylo-sequential: 19

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1369828&startday=2017-06-02&endday=2017-06-02&tree=all

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/60b41398d6c2

Comment 13

[Intermittent Failures Robot]

69 failures in 820 pushes (0.084 failures/push) were associated with this bug in the last 7 days. 

This is the #15 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 69

Platform breakdown:
* linux64-stylo: 51
* linux64-stylo-sequential: 18

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1369828&startday=2017-05-29&endday=2017-06-04&tree=all