1369929 - APZC tree printing is broken

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Botond Ballo [:botond]]

STR:
  1. Run a debug build of Nightly
  2. Enable the pref "apz.printtree"

Expected results:

  Readable dumps of the APZC tree are printed to stderr.

Actual results:

  The lines of the dumps have an unreasonable amount of space
  in front of them. The amount of space increases over time.

Probably a bug similar to one we had before where we are increasing the indentation level on the tree logger, and not decreasing it.

Comment 1

[Botond Ballo [:botond]]

This was regressed in bug 1227233.

TreeAutoIndent was given a copy constructor which delegates to the regular constructor, and also increases the indent in the constructor body. As a result, every time a TreeAutoIndent object is copied, the indent is increased twice: once in the body of the regular constructor, and once in the body of the copy constructor.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1369929 - Do not increase the indent twice in the TreeAutoIndent copy constructor.

Review commit: https://reviewboard.mozilla.org/r/145846/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145846/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8874481 [details]
Bug 1369929 - Do not increase the indent twice in the TreeAutoIndent copy constructor.

https://reviewboard.mozilla.org/r/145846/#review149794

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd1ece6b6180
Do not increase the indent twice in the TreeAutoIndent copy constructor. r=kats

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dd1ece6b6180