1369948 - Use 'rotate' by default in about:network HTTP logging

Status: NEW

(Core :: Networking, enhancement, P3)

Description

[Jason Duell]

There are times when we'll be telling people to turn on logging and browse around for a not-easily reproducible bug, and those folks will benefit from having rotate on by default.  And it shouldn't hurt people who have easy STR--their logs are unlikely to need to be more than a few MB anyway.

Bonus points: pick a rotate log size that's either less than the max Bugzilla attachment size (which I don't actually know), or statistically is very likely to compress to that size.

Comment 1

[Jason Duell]

I suspect Valentin could knock this off the most quickly.

Comment 2

[Honza Bambas (:mayhemer)]

(In reply to Jason Duell [:jduell] (needinfo me) from comment #0)
> There are times when we'll be telling people to turn on logging and browse
> around for a not-easily reproducible bug, and those folks will benefit from
> having rotate on by default.  And it shouldn't hurt people who have easy
> STR--their logs are unlikely to need to be more than a few MB anyway.
> 
> Bonus points: pick a rotate log size that's either less than the max
> Bugzilla attachment size (which I don't actually know), or statistically is
> very likely to compress to that size.

No.  Let them zip it, all the time (could we add a zip feature?).  The size should be, when there is also the nsSocketTransport:5 module active, at least 500MB or even more.  Note that child logs will never go over few megabytes.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

From what I recall, the rotate option was left out because it would have seriously complicated the implementation - races, etc.
I think we could implement it, either in Logging.cpp or in the NetworkingDashboard in JS, but I don't know at the moment how difficult that would be.

(In reply to Honza Bambas (:mayhemer) from comment #2)
> No.  Let them zip it, all the time (could we add a zip feature?).  The size
> should be, when there is also the nsSocketTransport:5 module active, at
> least 500MB or even more.  Note that child logs will never go over few
> megabytes.

Zipping would indeed be a useful feature. There's lots of improvement room for this tool.

Comment 4

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258