1369950 - update aom

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Ralph Giles (:rillian)]

Update to the current master of aom. This fixes a build issue on win64.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1369950 - Update av1 mimetype when vendoring.

We record the commit id of the aom library we vendor in the
gecko source so we can check it as part of the mimetype
to verify compatibility with the encoder while the stream
format is under development.

Make the vendor script update the hash in the code, just
like we do with README_MOZILLA. This can be removed when
the bitstream becomes stable.

Review commit: https://reviewboard.mozilla.org/r/145524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145524/

Comment 2

[Ralph Giles (:rillian)]

Attachment: Bug 1369950 - Remove aom_codec_stream_info_t sz field references.

Upstream has removed the requirement to set this when
initializing the stream_info struct.

Review commit: https://reviewboard.mozilla.org/r/145526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145526/

Comment 3

[Ralph Giles (:rillian)]

Attachment: Bug 1369950 - Update aom.

Update our in-tree copy of the aom reference implementation
of the av1 video codec to upstream git commit id
aadbb0251996c8ebb8310567bea330ab7ae9abe4.

This picks up recent changes and addresses a build issue on win64.

Review commit: https://reviewboard.mozilla.org/r/145528/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145528/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8874069 [details]
Bug 1369950 - Update av1 mimetype when vendoring.

https://reviewboard.mozilla.org/r/145524/#review149512

LGTM

::: python/mozbuild/mozbuild/vendor_aom.py:103
(Diff revision 1)
> +        filename = mozpath.join(self.topsrcdir,
> +                'dom/media/platforms/agnostic/AOMDecoder.cpp')
> +        with open(filename) as f:
> +            source = f.read()
> +
> +        # Substitue the new revision in lines like

'Substitue' -> 'Substitute'

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8874070 [details]
Bug 1369950 - Remove aom_codec_stream_info_t sz field references.

https://reviewboard.mozilla.org/r/145526/#review149514

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8874071 [details]
Bug 1369950 - Update aom.

https://reviewboard.mozilla.org/r/145528/#review149516

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8874069 [details]
Bug 1369950 - Update av1 mimetype when vendoring.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145524/diff/1-2/

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8874070 [details]
Bug 1369950 - Remove aom_codec_stream_info_t sz field references.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145526/diff/1-2/

Comment 9

[Ralph Giles (:rillian)]

Comment on attachment 8874071 [details]
Bug 1369950 - Update aom.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145528/diff/1-2/

Comment 10

[Ralph Giles (:rillian)]

Comment on attachment 8874069 [details]
Bug 1369950 - Update av1 mimetype when vendoring.

https://reviewboard.mozilla.org/r/145524/#review149512

> 'Substitue' -> 'Substitute'

Thanks!

Comment 11

[Nathan Froyd [:froydnj]]

Comment on attachment 8874069 [details]
Bug 1369950 - Update av1 mimetype when vendoring.

https://reviewboard.mozilla.org/r/145524/#review149846

::: python/mozbuild/mozbuild/vendor_aom.py:106
(Diff revision 2)
> +            source = f.read()
> +
> +        # Substitute the new revision in lines like
> +        #   version.AppendLiteral("abcdef0124");
> +        prefix = 'version.AppendLiteral'
> +        new_source = re.sub(prefix + '\("[a-f0-9]+"\);',

Maybe make this match the exact number of characters in the commit hash, rather than just `+`?

Comment 12

[Ralph Giles (:rillian)]

Comment on attachment 8874069 [details]
Bug 1369950 - Update av1 mimetype when vendoring.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145524/diff/2-3/

Comment 13

[Ralph Giles (:rillian)]

Comment on attachment 8874070 [details]
Bug 1369950 - Remove aom_codec_stream_info_t sz field references.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145526/diff/2-3/

Comment 14

[Ralph Giles (:rillian)]

Comment on attachment 8874071 [details]
Bug 1369950 - Update aom.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145528/diff/2-3/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e709485195e6
Update av1 mimetype when vendoring. r=froydnj,gerald
https://hg.mozilla.org/integration/autoland/rev/67152605b367
Remove aom_codec_stream_info_t sz field references. r=gerald
https://hg.mozilla.org/integration/autoland/rev/12d353fc5067
Update aom. r=gerald

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e709485195e6
https://hg.mozilla.org/mozilla-central/rev/67152605b367
https://hg.mozilla.org/mozilla-central/rev/12d353fc5067