1370061 - turn off more warnings in crashreporter code

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Masatoshi Kimura [:emk]]

This is an MSVC counterpart of bug 1369788.

52:27.40 warning: toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:3762 [C4334] '<<': 32 ビット シフトの 結果が暗黙的に 64 ビットに変換されました (64 ビット シフトに意図的に変換しようとしましたか?)
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/processor/postfix_evaluator-inl.h:305 [C4146] 符号付きの値を代入する変数は、符号付き型にキャストしなければなりません。
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/processor/stackwalker_mips.cc:60 [C4804] '>': 演算中の 'bool' 型の使用方法が安全ではありません
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/processor/stackwalker_mips.cc:68 [C4804] '>': 演算中の 'bool' 型の使用方法が安全ではありません
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/third_party/libdisasm/x86_disasm.c:38 [C4312] '型キャスト': 'long' からより大きいサイズの 'void *' へ変換します。
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/third_party/libdisasm/x86_disasm.c:56 [C4312] '型キャスト': 'long' からより大きいサイズの 'void *' へ変換します。
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/third_party/libdisasm/x86_disasm.c:62 [C4312] '型キャスト': 'long' からより大きいサイズの 'void *' へ変換します。
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/third_party/libdisasm/x86_disasm.c:180 [C4312] '型キャスト': 'long' からより大きいサイズの 'void *' へ変換します。

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1370061 - turn off more warnings in crashreporter code. .mielczarek

Review commit: https://reviewboard.mozilla.org/r/145620/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145620/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8874192 [details]
Bug 1370061 - turn off more warnings in crashreporter code. .mielczarek

https://reviewboard.mozilla.org/r/145620/#review149772

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20b0cc57dc92
turn off more warnings in crashreporter code. r=ted.mielczarek

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/20b0cc57dc92

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

and there is data to show a reduction in compiler warnings:
== Change summary for alert #7045 (as of June 05 2017 21:08 UTC) ==

Improvements:

  3%  compiler warnings summary windows2012-64 opt      247.00 -> 239.00
  3%  compiler warnings summary windows2012-64 debug    254.00 -> 246.00
  3%  compiler warnings summary windows2012-64 pgo      267.67 -> 259.42
  2%  compiler warnings summary windows2012-32 opt      220.00 -> 216.00
  2%  compiler warnings summary windows2012-32 debug    226.00 -> 222.00
  2%  compiler warnings summary windows2012-32-noopt debug 230.00 -> 226.00
  2%  compiler warnings summary windowsxp opt           220.00 -> 216.67
  2%  compiler warnings summary windows2012-32 pgo      237.25 -> 233.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7045