1370071 - bilibili.com's user profiles loading failure after Bug 1348390

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[YF (Yang)]

STR:
Open https://space.bilibili.com/358422/ or other user profile.


Actual results:
All data loading failed. A message box popup.

Error in Web Console:
TypeError: e is undefined  app_6eb88f25.js:10:28831


Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2e07ae5b0b69519a59d2943b95534bade9b68758&tochange=8cb64c677091fe3f8ae587e931a5ffe24b997972

Comment 1

[Alice0775 White]

I can reproduce the problem on Win10 Nightly55.
And setting dom.xhr.lowercase_header.enabled=false fixes the problem.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Shawn, putting this on your radar so that we could better determine if we should flip the dom.xhr.lowercase_header.enabled as bug 1348390 comment 23 mentioned.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)
> Shawn, putting this on your radar so that we could better determine if we
> should flip the dom.xhr.lowercase_header.enabled as bug 1348390 comment 23
> mentioned.

Yes. I'm aware of these bugs and I will disable lowercase-header.

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Since Safari and Chrome already landed case-insensitive response header name to follow the latest XHR specification.
I think it's better to always check lowercase header names in XHR.getAllResponseHeaders().

See:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/_oxlCPNsrck/_LEAqIZDCAAJ

Comment 5

[Andrew Overholt [:overholt]]

Assigning to Shawn since he appears to already be working on this. That assignment can obviously end in a WONTFIX, Shawn :)

Comment 6

[Mike Taylor [:miketaylr]]

This WFM now in Nightly (even after flipping the pref back to true...?). Can you confirm, YF?

Comment 7

[YF (Yang)]

Yes.

Why not be FIXED? https://developer.mozilla.org/en-US/docs/Mozilla/Bugzilla/What_to_do_and_what_not_to_do_in_Bugzilla#Resolving_bugs_as_FIXED

Comment 8

[Mike Taylor [:miketaylr]]

Sure, we can close as FIXED.

(WFM in my previous comment is just an expression, not a formal bug resolution status)