1370102 - Make browser_console_dead_objects.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Comment 1

[(no longer active)]

Attachment: Make browser_console_dead_objects.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8874247 [details] [diff] [review]
Make browser_console_dead_objects.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event

Review of attachment 8874247 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_console_dead_objects.js
@@ +31,5 @@
>      Services.prefs.setBoolPref("devtools.chrome.enabled", true);
>      yield loadTab(TEST_URI);
> +    let dwu = content.window.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
> +                            .getInterface(Components.interfaces.nsIDOMWindowUtils);
> +    let winID = dwu.outerWindowID;

Please use `tab.linkedBrowser.outerWindowID` for this, in case we want to support e10s mode in these tests at some point. Or the no-cpows-in-tests rule gets turned on for this directory.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd5d16e7085
Make browser_console_dead_objects.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event; r=kmag

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5dd5d16e7085