1370148 - system-info.getProperty("host") has been removed bug devtools still references it.

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Bug 1361601 removed system-info.getProperty("host"). However, devtools still appears to reference it at http://searchfox.org/mozilla-central/rev/1a0d9545b9805f50a70de703a3c04fc0d22e3839/devtools/shared/discovery/discovery.js#179.

Devtools may want to replace this with a call to |Cc["@mozilla.org/network/dns-service;1"].getService(Ci.nsIDNSService).myHostName|

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1370148 - Stop using the missing system-info.getProperty(host);

Review commit: https://reviewboard.mozilla.org/r/145750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145750/

Comment 2

[Patrick Brosset <:pbro>]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b314616e5c69bcd390bf26ab600f39fba3c91296

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8874388 [details]
Bug 1370148 - Stop using the missing system-info.getProperty(host);

https://reviewboard.mozilla.org/r/145750/#review149774

Thanks, looks good to me! :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cc0b9a19f37
Stop using the missing system-info.getProperty(host); r=jryans

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5cc0b9a19f37