Open Bug 1370285 Opened 7 years ago Updated 1 month ago

stylo: Don't store AncestorHashes in the parsed representation of selectors

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

Tracking Status
firefox57 --- wontfix

People

(Reporter: bholley, Unassigned)

References

(Blocks 1 open bug)

Details

Followup from the discussion in bug 1370107 comment 14. This would save 16 bytes for every selector in an in-memory stylesheet, which could be tens of kilobytes.

The down side of doing this is that we'd need to compute them in stylist::update instead, which is never less than the number of times we parse, and might be more. But the upside is that we plan to do a coarse-grained parallelization of stylist::update in bug 1362538, so at least doing it there will let it potentially parallelize with other work.

Probably worth measuring the impact of this change on stylist::update for the 100x myspace testcase.
Priority: -- → P4
status-firefox57=wontfix unless someone thinks this bug should block 57
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.