Closed
Bug 1370530
Opened 7 years ago
Closed 7 years ago
Convert more CSS filters to WebRender display items
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mrobinson, Assigned: mrobinson)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.81 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Now that WebRender is enabled for a few filters, we should enable the ones that only introduce <1 pixel differences in reference tests.
|
Assignee | |
Updated•7 years ago
|
Blocks: wr-displayitems
Depends on: 1365972
|
||
Comment 1•7 years ago
|
||
Blur is the most commonly used filter so it be nice to get that one done first.
|
|
||
Comment 2•7 years ago
|
||
Even if we can't turn blur on by default it would be good to have the code in place so that we can do some rough performance testing.
|
|
Assignee | |
Comment 3•7 years ago
|
||
I wasn't going to enable blur in this bug, bug I've opened https://bugzilla.mozilla.org/show_bug.cgi?id=1370564 to track this. I should be able to get a patch for rudimentary performance testing fairly easily.
|
|
Assignee | |
Comment 4•7 years ago
|
||
Activate WebRender output for filters that introduce only one pixel differences in tests. Since the filters spec does not seem to specify how color values are rounded, this output should be spec compliant.
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8875185 -
Flags: review?(rhunt)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8875185 -
Flags: review?(rhunt)
|
|
Assignee | |
Comment 5•7 years ago
|
||
Activate WebRender output for filters that introduce only one pixel differences in tests. Since the filters spec does not seem to specify how color values are rounded, this output should be spec compliant.
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8875185 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•7 years ago
|
||
Comment on attachment 8875237 [details] [diff] [review] Convert more CSS filters to WebRender display items Here is the try run for this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4729bdddd864fa5fecea7f918e59c96c5d80b59d&selectedJob=105143389
Attachment #8875237 -
Flags: review?(rhunt)
|
|
||
Updated•7 years ago
|
Attachment #8875237 -
Flags: review?(rhunt) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
|
||
Updated•7 years ago
|
Assignee: nobody → mrobinson
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0048424c784a Convert more CSS filters to WebRender display items. r=jrmuizel
Keywords: checkin-needed
|
|
||
Comment 8•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0048424c784a
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•