1370584 - The main photon menu can be cut off if Nightly is too low on the screen

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Dave Townsend [:mossop]]

It's possible to move the main window down low enough that the main menu is cut off when opened. Perhaps it should be scrollable in this case.

Comment 1

[:Gijs (he/him)]

Aaron, what would you expect to happen in this case? And in particular, would you expect parts (like maybe the quit button, sync item if signed in, any notification banners (updates, addons) at the top) to be outside the scrollable area, if indeed we want to scroll in this case?

Comment 2

[Aaron Benson]

I might need a little more context here .. when I move the browser window close to the bottom of my screen (in Windows and macOS) and then I open the main menu (hamburger / application menu), the menu opens above the hamburger icon. It seems to me we're already doing some edge detection and doing the right thing.

Am I looking in the wrong place?

Comment 3

[:Gijs (he/him)]

(In reply to Aaron Benson from comment #2)
> I might need a little more context here .. when I move the browser window
> close to the bottom of my screen (in Windows and macOS) and then I open the
> main menu (hamburger / application menu), the menu opens above the hamburger
> icon. It seems to me we're already doing some edge detection and doing the
> right thing.
> 
> Am I looking in the wrong place?

Try moving it to the middle, so that no matter whether you open to the top or the bottom, there isn't enough space.

Comment 4

[:Gijs (he/him)]

FWIW, it might help to look at how we solve this in the current hamburger panel (where you can make this situation easier to reproduce by filling it up with extra icons)

Comment 5

[Aaron Benson]

I see ... had to switch to a smaller resolution :) 

Yeah, we should allow for scrolling in this case. I don't think we need to pin any items in the menu.

Comment 6

[:Gijs (he/him)]

I think this might have been fixed by bug 1369095. It seems to work well on OS X for me now. Grover, can you check? (I left str in bug 1369095)

Comment 7

[Dave Townsend [:mossop]]

Seems fixed to me

Comment 8

[u554753]

Attachment: Screen Shot 2017-06-27 at 9.48.54 AM.png

Can still reproduce with yesterday's Nightly build on OSX. I moved the window to the far lower-left corner and still seeing Photon menu cut-off. Screenshot attached.

Comment 9

[u554753]

Windows and Linux builds from the same date work as intended.

Comment 10

[:Gijs (he/him)]

(In reply to Grover Wimberly IV [:Grover-QA] from comment #8)
> Created attachment 8881414 [details]
> Screen Shot 2017-06-27 at 9.48.54 AM.png
> 
> Can still reproduce with yesterday's Nightly build on OSX. I moved the
> window to the far lower-left corner and still seeing Photon menu cut-off.
> Screenshot attached.

OK, but that particular edgecase (with the menu button below the space taken up by the dock, and because the panel can't overlap the dock) reproduces with the old-style hamburger menu as well, so isn't the same as this bug (kind of a shame we didn't have a screenshot of the issue this got filed for). If that's the only edgecase, I think we can still mark this WFM. I'm not really too bothered about fixing that edgecase, either, as it just doesn't seem like something users will ever want to do particularly, so not bothering with a followup issue either.