1371073 - Add tests to ensure changing number of rows or columns in a frameset works as expected

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Robin Steuber (they/them) [:bytesized]]

I noticed that some incorrect code that I wrote where (effectively) |HTMLFrameSetElement::mCurrentRowColHint| was always set to |NS_STYLE_HINT_REFLOW| broke no tests.

Manual tests for this already exist at these locations:
 - https://bug48422.bmoattachments.org/attachment.cgi?id=90746
 - https://bug48422.bmoattachments.org/attachment.cgi?id=90747

When these tests are run with the buggy code I wrote, the frames seem to be added fine, but when removed, nothing is displayed on the page.

Comment 1

[Robin Steuber (they/them) [:bytesized]]

Attachment: Bug 1371073 - Add reftests to ensure rows and cols are properly added and removed from framesets

Review commit: https://reviewboard.mozilla.org/r/149214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149214/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8877788 [details]
Bug 1371073 - Add reftests to ensure rows and cols are properly added and removed from framesets

https://reviewboard.mozilla.org/r/149214/#review154304

r=me.

Did you happen to check whether some of these fail with the buggy bits from bug 1365092?

Comment 3

[Robin Steuber (they/them) [:bytesized]]

I did check and the "remove" tests both fail in that situation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9afdcc193530
Add reftests to ensure rows and cols are properly added and removed from framesets r=bz

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9afdcc193530