Closed Bug 1371095 Opened 7 years ago Closed 7 years ago

ImageTracker does unnecessary hashtable lookups

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Project Flags:
Performance Impact high
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

Details

(Keywords: perf)

Attachments

(1 file)

Avoid doing unnecessary hashtable lookups in ImageTracker::Add/Remove
3.16 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
      No description provided.
Could you post a sentence or two about which particular calls you're concerned with here?

We just ran across this bug in [qf] nomination bug triage, and we have no idea how to prioritize it. :)  Eliminating hashtable lookups is big, though, clearly, so this is probably [qf:p1] assuming that there's something to be done here.

(Alternately: maybe you've got a patch nearly ready, which will make this clearer...)
Flags: needinfo?(mats)
Fairly straightforward: replace Get+Put with LookupForAdd,
and Get+Remove with LookupRemoveIf.
Attachment #8876106 - Flags: review?(nfroyd)
Attachment #8876106 - Flags: review?(nfroyd) → review+
Triaging as [qf:p1], as straightforward removal of redundant hashtable lookups (known in general to be involved in QF perf issues).
Whiteboard: [qf] → [qf:p1]
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46cb9923c169
Avoid doing unnecessary hashtable lookups in ImageTracker::Add/Remove.  r=froydnj
https://hg.mozilla.org/mozilla-central/rev/46cb9923c169
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Component: DOM → DOM: Core & HTML
Performance Impact: --- → P1
Whiteboard: [qf:p1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: