1371107 - stylo: Clear mElementsToRestyle at the end of PreTraverse()

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

We have some situation that mElementsToRestyle still has elements that has been already unbinded (or something?), we should clear those elements at the end of PreTraverse().

The only case I found is that pseudo element during reframing. There might be other cases though.

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Bug 1370123 added something roughly equivalent to this (only for an unthrottled restyle of the root):

  http://searchfox.org/mozilla-central/diff/4ec9d9a3c92e7e11585dad6c502560aeced5b65a/dom/animation/EffectCompositor.cpp#1094

Is that enough?

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I guess not. The case in comment 0 happens on normal restyle (i.e. not flushThrottledRestyles).

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Do you have a test case for this?

Depending on the symptoms, we might just WONTFIX this. The change from bug 1370123 means we will eventually clean up mElementsToRestyle although it might take a few frames longer. If clearing these elements for other cases is expensive then it may be acceptable to keep them around a little longer.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

I haven't it yet, also I don't recall exactly the situation for now. I you are confident it's discarded in a later frame. Let's close this.

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Closing this for now based on comment 4 (i.e. we don't have a test case that triggers this situation).