Closed
Bug 1371292
Opened 7 years ago
Closed 7 years ago
Clean up various ESLint global definitions in config files across the tree
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(2 files)
There's a few places across the tree where globals are defined unnecessarily in .eslintrc.js files. We should tidy those up and switch to using importing of globals where necessary or environments as appropriate. In a few places I've had to define both global & exported as simply defining something as global will say it isn't used (extensions/ has "all" no unused vars turned on). We should probably change our globals code at some stage to additionally use the exported indication, but lets leave that for another bug.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8875737 [details] Bug 1371292 - Clean up more ESLint global definitions in configuration files in toolkit/ and browser/. https://reviewboard.mozilla.org/r/147164/#review151524
Attachment #8875737 -
Flags: review?(dtownsend) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8875738 [details] Bug 1371292 - Clean up more ESLint global definitions in configuration files in mobile/android. https://reviewboard.mozilla.org/r/147166/#review151532
Attachment #8875738 -
Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/27f5231ba905 Clean up more ESLint global definitions in configuration files in toolkit/ and browser/. r=mossop https://hg.mozilla.org/integration/autoland/rev/4ed96242e485 Clean up more ESLint global definitions in configuration files in mobile/android. r=mossop
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/27f5231ba905 https://hg.mozilla.org/mozilla-central/rev/4ed96242e485
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•6 years ago
|
Product: Testing → Firefox Build System
Updated•5 years ago
|
Version: Version 3 → 3 Branch
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•