1371701 - Permaorange in browser_content_sandbox_fs.js when Gecko 55 merges to beta on 2017-06-12

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: merge bustage, closed tree, delayed b1

Something that landed in the last couple days is going to cause browser_content_sandbox_fs.js to permafail when we merge to beta on Monday. Unless there's an easy test-only fix, we should probably consider backing out the regressing patch at this point to minimize risk to the merge.

https://treeherder.mozilla.org/logviewer.html#?job_id=105629299&repo=try

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Hah, yeah, this is an easy one. I'll have a patch up momentarily.

Comment 2

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1371701 - Fixed sandboxing tests to reflect that we're enabling file content process for all channels

Review commit: https://reviewboard.mozilla.org/r/147570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147570/

Comment 3

[Alex Gaynor [:Alex_Gaynor]]

Comment on attachment 8876161 [details]
Bug 1371701 - Fixed sandboxing tests to reflect that we're enabling file content process for all channels

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147570/diff/1-2/

Comment 4

[Bob Owen (:bobowen)]

Comment on attachment 8876161 [details]
Bug 1371701 - Fixed sandboxing tests to reflect that we're enabling file content process for all channels

https://reviewboard.mozilla.org/r/147570/#review151864

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5378ea8f1894
Fixed sandboxing tests to reflect that we're enabling file content process for all channels r=bobowen

Comment 6

[Julien Cristau [:jcristau]]

marking as blocker for 55

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5378ea8f1894