Closed
Bug 1371710
Opened 7 years ago
Closed 7 years ago
Places should not be initialized before first paint
Categories
(Toolkit :: Places, enhancement)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.95 KB,
patch
|
Details | Diff | Splinter Review |
The code in nsBrowserGlue.js causing places to be initialized before we create the first browser window seems to be doing it by accident.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → florian
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
Try was green-ish for attachment 8876185 [details] [diff] [review] except for the startup test in which my blacklist was a bit too agressive: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1594de7529d88e9cccf58ae3525e7c6357b1c7b Here is a try push of the new version with the fixed blacklist: https://treeherder.mozilla.org/#/jobs?repo=try&revision=85838b5ba04bd3f959ef07de7a41a6ed6de5ffa5 I think this is now ready for review.
Attachment #8876312 -
Flags: review?(mconley)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8876185 -
Attachment is obsolete: true
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8876312 [details] [diff] [review] Patch v2 Review of attachment 8876312 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8876312 -
Flags: review?(mconley) → review+
|
|
||
Comment 4•7 years ago
|
||
I'll be eager to see what, if anything, this does to our ts_paint numbers. I'm 60% confident that we'll see an improvement.
|
|
Assignee | |
Comment 5•7 years ago
|
||
I'm failing to make the tests pass on Windows, and giving up, given that Marco is actively working on bug 1371677 which should help a lot. My current investigations show that on try on Windows some C++ code is starting places when we load a page from a JAR file (I suspect about:newtab).
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8876312 -
Attachment is obsolete: true
Pushed by florian@queze.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/2d3d1741941f Places should not be initialized before first paint, r=mconley.
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2d3d1741941f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•