1371860 - The 'Search' placeholder should appear immediately on about:home and about:newtab

Status: VERIFIED FIXED

(Firefox :: Search, enhancement, P1)

Description

[Florian Quèze [:florian]]

Currently the 'Search' placeholder is the last thing that's painted on about:home. It should be painted immediately with the rest of the page. I think the delay is due to passing the strings from the .properties file to the DOM using custom events in contentSearchUI.js (dispatchEvent(new CustomEvent("ContentSearchClient"...).

Getting the string from a dtd file at the same time as we get the aria label seems simpler/faster.

Comment 1

[Florian Quèze [:florian]]

Attachment: The 'Search' placeholder should appear immediately on about:home and about:newtab, r=

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8876331 [details] [diff] [review]
The 'Search' placeholder should appear immediately on about:home and about:newtab, r=

Review of attachment 8876331 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/browser.dtd
@@ +468,5 @@
>       This is set as the aria-label attribute for the search input box in the
>       in-content search UI, to be used by screen readers. -->
>  <!ENTITY contentSearchInput.label     "Search query">
> +<!-- LOCALIZATION NOTE (contentSearchInput.placeholder):
> +     This string should match searchPlaceholder from search.properties -->

Actually, instead of this comment, I think we should move the searchbar's placeholder to browser.dtd too. And while we are at it, we could remove the http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/searchbar.dtd file which contains only one string used by the searchbar (cmd_engineManager.label is a leftover from the previous search UI).

Comment 3

[Florian Quèze [:florian]]

Attachment: Patch v2

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8876599 [details] [diff] [review]
Patch v2

Review of attachment 8876599 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/24549b6535ec
The 'Search' placeholder should appear immediately on about:home and about:newtab, r=nhnt11.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/24549b6535ec

Comment 7

[Azmina]

I have reproduced this bug with Nightly 55.0a1 (2017-06-09) on Windows 8.1 (64 bit).

This bug's fix is verified on Latest Nightly  56.0a1.

Build ID : 20170615030208
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 8

[Fahima Zulfath]

The issue is no longer reproducible on Firefox 56.0a1. Tests were performed under Windows 10x64.
Build ID: 20170628030206
[bugday-20170628]

Comment 9

[Florian Quèze [:florian]]

Verified per comment 8.