1371952 - ProcessPriorityManager does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: IPC, enhancement, P3)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Use LookupForAdd/LookupRemoveIf to avoid unnecessary hashtable lookups

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8876425 [details] [diff] [review]
Use LookupForAdd/LookupRemoveIf to avoid unnecessary hashtable lookups

Review of attachment 8876425 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming you agree with the below.  If not, we should talk about it.

::: dom/ipc/ProcessPriorityManager.cpp
@@ +507,5 @@
> +    [] (RefPtr<ParticularProcessPriorityManager>& aValue) {
> +      aValue->ShutDown();
> +      return true; // remove it
> +    });
> +  mHighPriorityChildIDs.RemoveEntry(childID);

Shouldn't this really live inside the lambda in the LookupRemoveIf call as well?  I mean, it might not matter if it's done outside the lambda, but that would require a bit of examining to see whether that's safe, and putting it inside the lambda would definitely not change the behavior.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8876425 [details] [diff] [review]
Use LookupForAdd/LookupRemoveIf to avoid unnecessary hashtable lookups

Review of attachment 8876425 [details] [diff] [review]:
-----------------------------------------------------------------

Gah, flip flag.

Comment 4

[Mats Palmgren (inactive)]

I don't think it should matter, but I agree it's better to keep
the existing behavior exactly as you suggest.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7c41eeb1420
Use LookupForAdd/LookupRemoveIf to avoid unnecessary hashtable lookups.  r=froydnj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f7c41eeb1420