1372689 - Photon's "Open a new tab" and "List all tabs" buttons look fuzzy compared to the Windows 10 window controls

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Attachment: Screenshot.png

The grey-on-eggplant color border surrounding Nightly's "Open a new tab" and "List all tabs" buttons makes the buttons look fuzzy and out of focus compared to the crisp Windows 10 window controls adjacent to the buttons. Firefox 54's "Open a new tab" button is crisp, but its "List all tabs" button is fuzzy.

Please see the attached screenshot.

Comment 1

[Chris Peterson [:cpeterson]]

This is not a regression. This grey icon border landed in "color the title bar by default on Windows 10" bug 1367384. Note that the UI mockup in bug 1367384 comment 0 does not have a grey icon border:

https://people-mozilla.org/~shorlander/projects/photon/Mockups/windows-10.html

Here is my about:support graphics info, if that matters. My Windows 10 laptop has a HiDPI display.

Application Basics
------------------

Name: Firefox
Version: 56.0a1
Build ID: 20170613030203
Update Channel: nightly
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
OS: Windows_NT 10.0
Multiprocess Windows: 1/1 (Enabled by user)
Google Key: Found
Mozilla Location Service Key: Found
Safe Mode: false

Graphics
--------

Features
Compositing: Direct3D 11
Asynchronous Pan/Zoom: wheel input enabled; scrollbar drag enabled
WebGL 1 Driver WSI Info: EGL_VENDOR: Google Inc. (adapter LUID: 000000000000cbe3) EGL_VERSION: 1.4 (ANGLE 2.1.0.dec065540d5f) EGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses
WebGL 1 Driver Renderer: Google Inc. -- ANGLE (Intel(R) HD Graphics 530 Direct3D11 vs_5_0 ps_5_0)
WebGL 1 Driver Version: OpenGL ES 2.0 (ANGLE 2.1.0.dec065540d5f)
WebGL 1 Driver Extensions: GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object
WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_shader_texture_lod EXT_texture_filter_anisotropic EXT_disjoint_timer_query MOZ_debug OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context MOZ_WEBGL_lose_context MOZ_WEBGL_compressed_texture_s3tc MOZ_WEBGL_depth_texture
WebGL 2 Driver WSI Info: EGL_VENDOR: Google Inc. (adapter LUID: 000000000000cbe3) EGL_VERSION: 1.4 (ANGLE 2.1.0.dec065540d5f) EGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses
WebGL 2 Driver Renderer: Google Inc. -- ANGLE (Intel(R) HD Graphics 530 Direct3D11 vs_5_0 ps_5_0)
WebGL 2 Driver Version: OpenGL ES 3.0 (ANGLE 2.1.0.dec065540d5f)
WebGL 2 Driver Extensions: GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object
WebGL 2 Extensions: EXT_color_buffer_float EXT_texture_filter_anisotropic EXT_disjoint_timer_query MOZ_debug OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context MOZ_WEBGL_lose_context MOZ_WEBGL_compressed_texture_s3tc
Audio Backend: wasapi
Direct2D: true
DirectWrite: true (10.0.15063.413)
GPU #1
Active: Yes
Description: Intel(R) HD Graphics 530
Vendor ID: 0x8086
Device ID: 0x191b
Driver Version: 22.20.16.4691
Driver Date: 6-2-2017
Drivers: igdumdim64 igd10iumd64 igd10iumd64 igd12umd64 igdumdim32 igd10iumd32 igd10iumd32 igd12umd32
Subsys ID: 674e1a58
RAM: Unknown
GPU #2
Active: No
Description: NVIDIA GeForce GTX 970M
Vendor ID: 0x10de
Device ID: 0x13d8
Driver Version: 22.21.13.8205
Driver Date: 5-1-2017
Drivers: C:\WINDOWS\System32\DriverStore\FileRepository\nvrzwu.inf_amd64_594c7eb4ee6a7125\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvrzwu.inf_amd64_594c7eb4ee6a7125\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvrzwu.inf_amd64_594c7eb4ee6a7125\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvrzwu.inf_amd64_594c7eb4ee6a7125\nvldumdx.dll C:\WINDOWS\System32\DriverStore\FileRepository\nvrzwu.inf_amd64_594c7eb4ee6a7125\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvrzwu.inf_amd64_594c7eb4ee6a7125\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvrzwu.inf_amd64_594c7eb4ee6a7125\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvrzwu.inf_amd64_594c7eb4ee6a7125\nvldumd.dll
Subsys ID: 674e1a58
RAM: 6144
Diagnostics
ClearType Parameters: Gamma: 2.2 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50
AzureCanvasAccelerated: 0
AzureCanvasBackend: Direct2D 1.1
AzureCanvasBackend (UI Process): skia
AzureContentBackend: Direct2D 1.1
AzureContentBackend (UI Process): skia
AzureFallbackCanvasBackend (UI Process): cairo
GPUProcessPid: 6292
GPUProcess: Terminate GPU Process
ClearType Parameters: Gamma: 2.2 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50
Decision Log
WEBRENDER:
opt-in by default: WebRender is an opt-in feature

Comment 2

[Dão Gottwald [:dao]]

Mockups: https://mozilla.invisionapp.com/share/MRBK1MZF7#/screens/229786513

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1372689 - Update tab strip button icons.

Review commit: https://reviewboard.mozilla.org/r/159328/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159328/

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8888378 [details]
Bug 1372689 - Update tab strip button icons.

https://reviewboard.mozilla.org/r/159328/#review165114

The code looks good to me. It's great that we can get rid of those images.

There's one thing about this patch I'm struggling with: In non-Photon mode, using the default theme, the tab strip buttons now look much darker on OSX than before (they were light gray). It might be worth checking with shorlander if we should change the color back to gray on OSX for 56 at least.

::: browser/base/content/test/performance/browser_startup_images.js:59
(Diff revision 1)
> +    platforms: ["linux", "win", "macosx"],
> +  },
> +  {
> +    file: "chrome://browser/skin/arrow-dropdown.svg",
> +    platforms: ["linux", "win", "macosx"],
> +  },

As mentioned on IRC, considering that this bug probably didn't introduce the root problem I'm ok with adding these entries to the list, if we file a follow-up bug for cleaning them up.

::: browser/themes/osx/browser.css
(Diff revision 1)
> -  -moz-image-region: rect(0, 36px, 20px, 18px);
> -}
> -
> -.tabs-newtab-button:hover:active,
> -#TabsToolbar > #new-tab-button:hover:active {
> -  -moz-image-region: rect(0, 54px, 20px, 36px);

Note that we're removing the hover and active states from OSX without providing a replacement. I guess that's fine since we're going towards a unified style anyway. I suppose the new hover/active styles will be implemented separately.

Comment 5

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=223cad78f90c96d40369423e1fa2e2bbb5034e02

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7da25c837d8
Update tab strip button icons. r=johannh

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

FYI, your push introduced the following failure on autoland:
 FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/toolbarbutton-dropdown-arrow.png should have been loaded.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing browser-chrome's browser_startup_images.js about toolbarbutton-dropdown-arrow.png:

https://hg.mozilla.org/integration/autoland/rev/20344022a01d05928707dc47bf064b301ba2adf9

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a7da25c837d870a5b4e10d1a5911d3fafdf75592
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=117116095&repo=autoland

Ignore the unexpected pass, that's from jaws and got fixed later - it's about the unexpected fail:
> TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/toolbarbutton-dropdown-arrow.png should have been loaded. -

Comment 9

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)
> FYI, your push introduced the following failure on autoland:
>  FAIL | browser/base/content/test/performance/browser_startup_images.js |
> Whitelisted image chrome://browser/skin/toolbarbutton-dropdown-arrow.png
> should have been loaded.

Which did not happen on Try. Great.

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 8888378 [details]
Bug 1372689 - Update tab strip button icons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159328/diff/1-2/

Comment 11

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2929b20d22a3 -d 67aad6b837d4: rebasing 409076:2929b20d22a3 "Bug 1372689 - Update tab strip button icons. r=johannh" (tip)
merging browser/base/content/test/performance/browser_startup_images.js
merging browser/themes/linux/browser.css
merging browser/themes/linux/jar.mn
merging browser/themes/osx/browser.css
merging browser/themes/osx/jar.mn
merging browser/themes/shared/jar.inc.mn
merging browser/themes/linux/tabbrowser/newtab.svg and browser/themes/shared/tabbrowser/newtab.svg to browser/themes/shared/tabbrowser/newtab.svg
merging browser/themes/shared/tabs.inc.css
merging browser/themes/windows/browser.css
merging browser/themes/windows/jar.mn
warning: conflicts while merging browser/base/content/test/performance/browser_startup_images.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 12

[Johann Hofmann [:johannh]]

(In reply to Dão Gottwald [::dao] from comment #9)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)
> > FYI, your push introduced the following failure on autoland:
> >  FAIL | browser/base/content/test/performance/browser_startup_images.js |
> > Whitelisted image chrome://browser/skin/toolbarbutton-dropdown-arrow.png
> > should have been loaded.
> 
> Which did not happen on Try. Great.

The test was skipped on try on Windows 7:

https://treeherder.mozilla.org/logviewer.html#?job_id=117080250&repo=try&lineNumber=1692

No idea why.

Comment 13

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=181d61f638a5a6ccb16dd22ee4f8e39d00f639b2

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 8888378 [details]
Bug 1372689 - Update tab strip button icons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159328/diff/2-3/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3aafea4f6b1c
Update tab strip button icons. r=johannh

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3aafea4f6b1c

Comment 17

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=32d9d1e81cc607320a36391845917f645f7a7f72&newProject=mozilla-central&newRev=c6d36106525ba7b65a3587d643c3b145de80fb99

Comment 18

[ovidiu boca[:Ovidiu]]

I verified this on Mac Os X 10.10. 10.12, Ubuntu 16.04, Windows 10 and Windows 7 with Nightly 57.0a1(2017-08-20) and I can confirm the fix.