Closed
Bug 1372714
Opened 7 years ago
Closed 7 years ago
[AWSY] Add an option to output parse_about_memory.py results in mebibytes
Categories
(Testing :: AWSY, enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(2 files)
1.83 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
1.84 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
about:memory uses mebibytes, not bytes, which makes comparing the contents of about:memory to parse_about_memory.py very tedious.
Assignee | ||
Comment 1•7 years ago
|
||
This makes it easier to compare results to about:memory.
Attachment #8877305 -
Flags: review?(erahm)
Comment 2•7 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #1) > Created attachment 8877305 [details] [diff] [review] > Add an option to output parse_about_memory.py results in mebibytes. > > This makes it easier to compare results to about:memory. FWIW I just check 'verbose' when loading the report.
Comment 3•7 years ago
|
||
Comment on attachment 8877305 [details] [diff] [review] Add an option to output parse_about_memory.py results in mebibytes. Review of attachment 8877305 [details] [diff] [review]: ----------------------------------------------------------------- Not super stoked on '--mebi' but meh. |ls| has '-h' for 'human readable' ::: testing/awsy/awsy/parse_about_memory.py @@ +156,4 @@ > for (k, v) in sorted_totals: > if v: > + if args.mebi: > + print "{0:.2f}".format(v / bytes_per_mebibyte), Maybe include MiB (or just MB like about:memory) at the end of the value?
Attachment #8877305 -
Flags: review?(erahm) → review+
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #3) > Maybe include MiB (or just MB like about:memory) at the end of the value? That's a good idea. I'll also add "bytes" as the units in the default case.
Assignee | ||
Comment 5•7 years ago
|
||
This makes it easier to compare results to about:memory.
Attachment #8877691 -
Flags: review+
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/70e68a66dd9b8b46a47324d5bffe6a27cf01f337 Bug 1372714 - Add an option to output parse_about_memory.py results in mebibytes. r=erahm
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/70e68a66dd9b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•7 years ago
|
Component: General → AWSY
You need to log in
before you can comment on or make changes to this bug.
Description
•