Closed
Bug 1373135
Opened 7 years ago
Closed 7 years ago
Permared build bustage on Windows debug when Gecko 56 merges to beta on 2017-08-07
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox-esr45 | --- | unaffected |
| firefox-esr52 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | unaffected |
| firefox56 | + | fixed |
People
(Reporter: philor, Assigned: nical)
References
Details
Attachments
(1 file)
|
1.52 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
MSVC is not happy with bug 1370879 as it will be compiled on beta when mozilla-central merges there in August. https://treeherder.mozilla.org/logviewer.html#?job_id=107183228&repo=try 19:31:18 INFO - c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\src\gfx\webrender_bindings\renderthread.cpp(336) : error C2220: warning treated as error - no 'object' file generated 19:31:18 INFO - c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\src\gfx\webrender_bindings\renderthread.cpp(336) : warning C4722: 'mozilla::wr::WebRenderThreadPool::~WebRenderThreadPool': destructor never returns, potential memory leak 19:31:18 INFO - c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\src\gfx\webrender_bindings\renderthread.cpp(33) : warning C4722: 'mozilla::wr::RenderThread::~RenderThread': destructor never returns, potential memory leak [Tracking Requested - why for this release]: if it's not fixed, merge build bustage, closed tree, delayed b1.
|
Reporter | |
Updated•7 years ago
|
Flags: needinfo?(nical.bugzilla)
|
Assignee | |
Comment 1•7 years ago
|
||
This should fix the build on branches that don't build webrender.
Assignee: nobody → nical.bugzilla
Flags: needinfo?(nical.bugzilla)
Attachment #8877950 -
Flags: review?(bugmail)
|
||
Updated•7 years ago
|
Attachment #8877950 -
Flags: review?(bugmail) → review+
Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/79fbc260febf Mark wr_thread_pool_delete destructor-safe. r=kats
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/79fbc260febf
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•