Closed Bug 1373208 Opened 7 years ago Closed 7 years ago

Detect different push events and change the notification accordingly.

Categories

(Firefox for iOS :: Firefox Accounts, enhancement, P1)

Other
iOS
enhancement

Tracking

()

RESOLVED FIXED
Iteration:
1.28
Tracking Status
fxios 9.0 ---

People

(Reporter: jhugman, Assigned: jhugman)

References

(Depends on 5 open bugs)

Details

(Whiteboard: [MobileCore][Autopush])

Attachments

(1 file, 1 obsolete file)

Push notifications can be received when the user has verified the login, or added/removed a device, or password reset etc.

Currently, all of these are dealt by displaying a generic message: Firefox Sync, Tap to begin.

This bug is to detect the different (non sent tab) events are display better copy.
Blocks: 1373111
Iteration: --- → 1.24
Whiteboard: [MobileCore][Autopush]
Priority: -- → P2
Iteration: 1.24 → 1.25
Iteration: 1.25 → ---
Assignee: nobody → jhugman
Iteration: --- → 1.25
Priority: P2 → P1
Status: NEW → ASSIGNED
Iteration: 1.25 → 1.26
Iteration: 1.26 → 1.27
Iteration: 1.27 → 1.28
Adding strings-only PR to land as quickly as possible, and to be reviewed by the FxA/Sync team.
Attachment #8895346 - Flags: review?(rfeeley)
Attachment #8895346 - Flags: review?(eoger)
Attachment #8895346 - Flags: review?(eoger) → review+
Attachment #8894530 - Flags: review?(jdarcangelo)
Attachment #8894530 - Flags: feedback?(vfilippov)
Attachment #8894530 - Flags: feedback?(eoger)
Attachment #8894530 - Flags: feedback?(vfilippov)
Attachment #8894530 - Flags: feedback?(eoger)
Attachment #8895346 - Flags: review?(rfeeley)
Whiteboard: [MobileCore][Autopush] → [MobileCore][Autopush][Strings]
Attachment #8895346 - Attachment is obsolete: true
Whiteboard: [MobileCore][Autopush][Strings] → [MobileCore][Autopush]
Comment on attachment 8894530 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3008

I like the API changes here. See PR for comment asking about `PendingAccountDisconnectKey`.
Attachment #8894530 - Flags: review?(jdarcangelo) → review+
PendingAccountDisconnectKey coming from Bug 1333779.

Merged in to master.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [MobileCore][Autopush] → [MobileCore][Autopush][needsuplift]
Depends on: 1398124
Depends on: 1398186
Whiteboard: [MobileCore][Autopush][needsuplift] → [MobileCore][Autopush]
Removing needsuplift flag since this also is on v9.x
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: