Closed Bug 1373237 Opened 7 years ago Closed 6 years ago

Please make the 'finish review' button not green and attractive on own patches

Categories

(MozReview Graveyard :: Review Board: User Interface, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: Gijs, Unassigned)

Details

STR:

1. push patch
2. get review+
3. try to land patch by clicking the big green button, brainlessly select r+, click "finish review" because I do this several times a day.

ER:
land patch

AR:
mark patch r+ by self.


I have now done this more than once. I'm sure it's just me being distracted, but really, I also don't actually see the point of having a super-prominent 'finish review' button FOR YOUR OWN PATCHES. Like, it doesn't really make sense. The cases where you want to self-review your patch are few and far between.

Please green up the automation button instead for patches where the logged in user == the person pushing the patch.
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.