1373280 - Highlight private comments in new bug modal UI

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect, P1)

Description

[[e-mail] (:bhearsum)]

This is quite the edge case, but I was looking at a bug from a couple of years ago where I had made some private comments. Since then, I've been removed from the "core security" group. In the new UI, these comments (such as https://bugzilla.mozilla.org/show_bug.cgi?id=1139929#c20) show up exactly the same as other comments - there's no indication that they are private. In the old UI, they are coloured differently.

Comment 1

[Daniel Veditz [:dveditz]]

If you're not in the security groups you shouldn't be able to see the private comment at all, even if it's yours! The example comment above, though, was made not-private a short while after this bug was filed. A current private comment is bug  1396466 comment 11

I completely agree that private comments are no longer distinguishable enough in the new UI. There's a little word "Private" over by the tag button (or perhaps more importantly, the reply button), but the text color or background color are identical as you read down the bug. A different visual style would be nice.

Comment 3

[Daniel Veditz [:dveditz]]

comment 2 in this bug is a private comment. The comment does have the bz-private class, which is defined as

.bz_private {
	color: darkred;
	background: #f3eeee;
}

This is not having the intended effect. I can make it work by adding !important to each style. The .comment-text style seems to win so you might also be able to make it work by reversing the order these are defined.

Comment 5

[Israel Madueme [:imadueme]]

Attachment: Github PR #545