Closed
Bug 1373281
Opened 7 years ago
Closed 7 years ago
Crash in mozilla::ThreadStackHelper::FillStackBuffer
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | unaffected |
| firefox56 | --- | fixed |
People
(Reporter: calixte, Assigned: nika)
References
(Blocks 1 open bug)
Details
(Keywords: crash, regression, Whiteboard: [clouseau])
Crash Data
Attachments
(1 file)
|
1.98 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-ad27b2c3-1809-4c65-8fbe-5ad010170615. ============================================================= There are 2 crashes in nightly 56 with buildid 20170615030208. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1357829. [1] https://hg.mozilla.org/mozilla-central/rev?node=6123a6b2b7495adb14e753f3b3999a9beceb060f
Flags: needinfo?(michael)
|
Assignee | |
Comment 1•7 years ago
|
||
This was causing a crash on nightly. The browser would try to collect only a native stack, and then attempt to dereference the null pointer for the pseudostack. I think this didn't happen on infra as it only occurs when the user has hung a sufficient number of times. MozReview-Commit-ID: 6RSW2llKBjT
Attachment #8878077 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → michael
Flags: needinfo?(michael)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8878077 [details] [diff] [review] Null-check mStackToFill before collecting psuedostacks Review of attachment 8878077 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #8878077 -
Flags: review?(nfroyd) → review+
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c83344a41561 Null-check mStackToFill before collecting psuedostacks, r=froydnj
|
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c83344a41561
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Comment 5•7 years ago
|
||
This is topcrash #4 for the Windows nightly of 20170615030208. Presumably it will disappear when the fix makes it into the nightly channel.
You need to log in
before you can comment on or make changes to this bug.
Description
•