1373284 - Thunderbird 55.0b1 build1: build step failed on macosx64 - No such file or directory: ... /builds/slave/tb-rel-c-beta-m64_bld-00000000/build/objdir-tb/55.0b1.crashreporter-symbols-full.zip' because of pretty name

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P2)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #1369479 +++


IRC mtabara|mtg	weird, sounds like crashreporter-symbols-full.zip artifact is missing

from https://archive.mozilla.org/pub/thunderbird/candidates/55.0b1-candidates/build1/logs/release-comm-beta-macosx64_build-bm84-build1-build18.txt.gz

make buildsymbols
...
echo packing symbols
packing symbols
./config/nsinstall -D dist/mac/en-US/
rm -f 'dist/mac/en-US/Thunderbird 55.0b1.crashreporter-symbols-full.zip'
/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/objdir-tb/_virtualenv/bin/python -m mozbuild.action.symbols_archive /builds/slave/tb-rel-c-beta-m64_bld-00000000/build/objdir-tb/'dist/mac/en-US/Thunderbird /builds/slave/tb-rel-c-beta-m64_bld-00000000/build/objdir-tb/55.0b1.crashreporter-symbols-full.zip' /builds/slave/tb-rel-c-beta-m64_bld-00000000/build/objdir-tb/dist/crashreporter-symbols --exclude '*test*' --exclude '*Test*' --compress '**/*.sym'
Traceback (most recent call last):
  File "/tools/python/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/tools/python/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/mozilla/python/mozbuild/mozbuild/action/symbols_archive.py", line 44, in <module>
    main(sys.argv[1:])
  File "/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/mozilla/python/mozbuild/mozbuild/action/symbols_archive.py", line 41, in main
    make_archive(args.archive, args.base, args.exclude, args.include, args.compress)
  File "/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/mozilla/python/mozbuild/mozbuild/action/symbols_archive.py", line 22, in make_archive
    with open(archive_name, 'wb') as fh:
IOError: [Errno 2] No such file or directory: '/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/objdir-tb/dist/mac/en-US/Thunderbird /builds/slave/tb-rel-c-beta-m64_bld-00000000/build/objdir-tb/55.0b1.crashreporter-symbols-full.zip'
make: *** [symbolsfullarchive] Error 255
program finished with exit code 2

Comment 1

[Wayne Mery (:wsmwk)]

releasing without Mac is not a great option.

Is this assumed to be a fixable bug, and rerunning the step (which we haven't done yet) won't help?

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #0)
> IOError: [Errno 2] No such file or directory:
> '/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/objdir-tb/dist/mac/en-US/
> Thunderbird
> /builds/slave/tb-rel-c-beta-m64_bld-00000000/build/objdir-tb/55.0b1.
> crashreporter-symbols-full.zip'
> make: *** [symbolsfullarchive] Error 255
> program finished with exit code 2

I doubt it will help, the ".../Thunderbird /builds/..." there strongly implies an issue with pretty name support.

Comment 3

[Wayne Mery (:wsmwk)]

Can someone take a shot at a patch?  This is very soon going to impact 55.3.0, because of inability to test patches for uplift.


(In reply to Jorg K (GMT+2) from bug 1360700 comment #18)
> The bad news is that bug 1329355 cannot be backed out from Mozilla Beta at
> version 55 any more due to merge conflicts.
> 
> If I understand it correctly, we need to add back in the "pretty stuff", but
> the file(s) where to add it back in have changed meanwhile. Also, under
> these circumstances it's hard to tell whether any manually "nurtured"
> backout will be correct.
> 
> Since this was a dead end to start with, I suggest we abandon this approach
> and fix the bug for real.

Comment 4

[Jorg K (CEST = GMT+2)]

You mean "going to impact 52.3".

Tom, I already enquired about this in bug 1360700. We've been backing out bug 1329355 for TB 54 beta (bug 1360700) and last for TB 55 beta (bug 1372698), but this time it hasn't bought us anything and we really need to address the source problem.

Comment 5

[Tom Prince [:tomprince]]

I think this is fixed. The beta process worked (I think even without backing out the pretty names revert?).

Comment 6

[Jorg K (CEST = GMT+2)]

OK, let's close this and open a new one for TB 56 beta if required.

Since I messed up our TB 55 beta 2 release branch on M-B, the beta got built with the pretty stuff backed out (bug 1372698), so we can't tell for sure whether bug 1379785 alone would have fixed it.
See: https://hg.mozilla.org/releases/mozilla-beta/graph/THUNDERBIRD550b2_2017071407_RELBRANCH

We'll see when TB 56 beta comes around.

Comment 7

[Tom Prince [:tomprince]]

> the beta got built with the pretty stuff backed out

If that is the case, then I think we should default to backing them out for TB56 too. I think the later release automation depends on the pretty names. I plan to address this, but I have some other yaks to shave first.