1373294 - Update flake8 linter to version 3.3.0

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Andrew Halberstadt [:ahal]]

This is a major update from the previous version. The reason I'd like to upgrade is that it fixes some configuration bugs we were previously working around (see bug 1277851) and provides the ability to run in parallel, making it much faster.

It looks like it flags a new kind of error (E305) which enforces two whitespaces after the file. I'll fix those using autopep8.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1373294 - Fix E305 (two blank lines after method or class) in files enabled by flake8 linter,

This is needed before we can upgrade to flake8 3.3.0, as that version starts flagging these errors.

These files were modified by running:
autopep8 --select E305 --in-place -r <dir>

on the affected directories. I did it one dir at a time and verified the result after each.

Review commit: https://reviewboard.mozilla.org/r/149510/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149510/

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1373294 - Update flake8 used to version 3.3.0,

This file was generated using:
hashin -r tools/lint/flake8_/flake8_requirements.txt flake8==3.3.0 mccabe pycodestyle pyflakes enum34 configparser

Review commit: https://reviewboard.mozilla.org/r/149512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149512/

Comment 3

[Andrew Halberstadt [:ahal]]

Here's the try run proving flake8 3.3.0 got installed.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8878109 [details]
Bug 1373294 - Fix E305 (two blank lines after method or class) in files enabled by flake8 linter,

https://reviewboard.mozilla.org/r/149510/#review154088

yay whitespace

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8878110 [details]
Bug 1373294 - Update flake8 used to version 3.3.0,

https://reviewboard.mozilla.org/r/149512/#review154090

rubber stamp

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8878109 [details]
Bug 1373294 - Fix E305 (two blank lines after method or class) in files enabled by flake8 linter,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149510/diff/1-2/

Comment 7

[Andrew Halberstadt [:ahal]]

Comment on attachment 8878110 [details]
Bug 1373294 - Update flake8 used to version 3.3.0,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149512/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a51da7e10a0
Fix E305 (two blank lines after method or class) in files enabled by flake8 linter, r=jmaher
https://hg.mozilla.org/integration/autoland/rev/43d96b2dd775
Update flake8 used to version 3.3.0, r=jmaher

Comment 9

[Andrew Halberstadt [:ahal]]

Oops, I never posted that try run I promised:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=473a61b78bda4caf68460da5b5b6d5a9052211e3

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5a51da7e10a0
https://hg.mozilla.org/mozilla-central/rev/43d96b2dd775