1373709 - Infinite restart loop for tests that are expected to crash

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[James Graham [:jgraham]]

Because we want to restart before running a test that crashes for the leak checker, but don't cehck if we already restarted once.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1373709 - Don't infinite loop when a test expects to crash,

In order to avoid the leak checker complaining about missing output,
we restart the browser before running tests that are expected to
crash. But as part of that restart we end up checking again if a
restart is required and so end up in an infinite loop. To break out of
that loop we simply check if this is the same test as during the last
iteration, and don't ask to restart in that case.

Review commit: https://reviewboard.mozilla.org/r/149874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149874/

Comment 2

[James Graham [:jgraham]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=91c6bef9b375abe934cd2da30320754647953893 should verify if this works

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8878553 [details]
Bug 1373709 - Don't infinite loop when a test expects to crash,

https://reviewboard.mozilla.org/r/149874/#review154548

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28141f8a1de2
Don't infinite loop when a test expects to crash, r=ato

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/28141f8a1de2