1373818 - Treat Adjust distribution parameter the same as the mozilla parameter

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Mike Kaply [:mkaply]]

So we're working with Adjust to try to track installs that happen with a referrer intent.

To do that, they are enabling using the utm_source parameter to pass an Adjust tracking token.

For our purposes, that means we need to treat the adjust tracking token that we've already assigned for distributions as if it is the utm_source "mozilla"

The token in question is xodfft.

When third parties use a referrer intent, they will send it to us like this:

utm_source=xodfft&utm_content=wildtangent&utm_campaign=distribution&utm_term=browse&utm_store=true"

and adjust will be able to track that even though it didn't originate with an Adjust URL.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1373818 - Don't hardcode our tracker per Adjust.

Review commit: https://reviewboard.mozilla.org/r/149978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149978/

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8878673 [details]
Bug 1373818 - Don't hardcode our tracker per Adjust.

https://reviewboard.mozilla.org/r/149978/#review154674

I believe this does what you intend it to.

Comment 3

[Mozilla Autoland]

hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev d6e88a4c9667 needs "Bug N" or "No bug" in the commit message.
remote: Michael Kaply <[e-mail]>
remote: Bug #1373818 - Allow Adjust campaign ID to behave as OTA distribution. r=rnewman
remote: 
remote: MozReview-Commit-ID: 8MEQ84PuH7i
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 8878673 [details]
Bug 1373818 - Don't hardcode our tracker per Adjust.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149978/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12f0f85e4ade
Allow Adjust campaign ID to behave as OTA distribution. r=rnewman

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/12f0f85e4ade

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 8878673 [details]
Bug 1373818 - Don't hardcode our tracker per Adjust.

Approval Request Comment
[Feature/Bug causing the regression]: Allow Adjust tracking in more situations.
[User impact if declined]: No user impact. Allow us better tracking.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Extremely low.
[Why is the change risky/not risky?]: Only used when a referrer intent is executed
[String changes made/needed]: None

This patch basically gives us another parameter that marks something as an OTA distribution but in this case, it also sends additional info to Adjust to allow it to be tracked.

Adjust is targeting an update fairly soon to enable this functionality, so we want to get it in as soon as possible.

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8878673 [details]
Bug 1373818 - Don't hardcode our tracker per Adjust.

install tracking for fennec, beta55+

Comment 9

[Mike Kaply [:mkaply]]

Adjust changed the API on us so we don't need this in beta. There will be a different patch. Sorry for the duplicate work here.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/607eded6754d

Comment 11

[Mike Kaply [:mkaply]]

Adjust changed the API on us, so sadly new patch coming.

Comment 12

[Mike Kaply [:mkaply]]

Comment on attachment 8878673 [details]
Bug 1373818 - Don't hardcode our tracker per Adjust.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149978/diff/2-3/

Comment 13

[Mike Kaply [:mkaply]]

Ryan:

I ended up needing to change the name of the tracker, but it's the same review request, so I don't see how to ask for this update to go to beta as well. Thanks for any help you can provide.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

From a work tracking standpoint, it would probably be better to just file a new bug for renaming it.

Comment 15

[Mike Kaply [:mkaply]]

Will do.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77a37c261feb
Don't hardcode our tracker per Adjust. r=rnewman

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/77a37c261feb

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1dbc2921bc37