1373828 - stylo: workaround servo/rust-bindgen#734

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

With the bindgen update, nsPresContext in debug mode is wrongly sized, because of  https://github.com/servo/rust-bindgen/issues/734.

Before https://github.com/servo/rust-bindgen/pull/736, the result wasn't particularly better, because the bitfield accessors in nsPresContext were wrong (which is IMO more problematic).

I don't know what the best way to fix https://github.com/servo/rust-bindgen/issues/734 is yet (because all of the ways to do so I can think of are really ugly), but the workaround Gecko-side is easy enough.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1373828: Work around servo/rust-bindgen#734.

Review commit: https://reviewboard.mozilla.org/r/150014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150014/

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8878700 [details]
Bug 1373828: Work around servo/rust-bindgen#734.

https://reviewboard.mozilla.org/r/150014/#review154698

r=me with a bug filed to run the struct layout tests as part of mach check.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/956c34d23e87
Work around servo/rust-bindgen#734. r=bholley

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/956c34d23e87