1373863 - Add basic invalidation to PaintedLayerBlobImage

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

This makes things noticeably better.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add simple invalidation to PaintedLayerBlob

This allows us to reuse blob images if they haven't changed. If they have changed we repaint the whole image.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8878718 [details] [diff] [review]
Add simple invalidation to PaintedLayerBlob

Review of attachment 8878718 [details] [diff] [review]:
-----------------------------------------------------------------

Is this the right patch? Looks unrelated. Also please make sure there's a real commit message and -U8 diff

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8878718 [details] [diff] [review]
Add simple invalidation to PaintedLayerBlob

Review of attachment 8878718 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah definitely the wrong patch here.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: The right patch

Comment 5

[Markus Stange [:mstange]]

If this merges to central after bug 1368386 (which seems likely), it'll need to be changed to
AddToValidRegion(regionToPaint);

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efc25dfc9956
Add basic invalidation to PaintedLayerBlobImage. r=kats

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efc25dfc9956