Closed Bug 1373891 Opened 7 years ago Closed 7 years ago

Crash in java.lang.ClassCastException: org.mozilla.gecko.tabqueue.TabQueuePrompt cannot be cast to android.support.v4.app.FragmentActivity at org.mozilla.gecko.IntentHelper.openUriExternal(IntentHelper.java)

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
Unspecified
Android
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(fennec+, firefox54 unaffected, firefox55 fixed, firefox56 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
fennec + ---
firefox54 --- unaffected
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: Grisha, Assigned: jchen)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

Support Activities other than main Fennec Activity in openUriExternal (v1)
1.64 KB, patch
jchen
: review+
lizzard
: approval-mozilla-beta+
Details | Diff | Splinter Review 
This bug was filed from the Socorro interface and is 
report bp-e423da83-56ba-4d96-9334-7c7a80170615.
=============================================================

Seems like we're making some false assumptions while processing outgoing URIs.
Mike, I think you were the last one to touch this code. Do you know what could be going wrong here?
Flags: needinfo?(michael.l.comella)
tracking-fennec: --- → ?
It looks like the changes from Bug 1363167 (d15e744f0008) are likely the cause.

Assuming this isn't urgent, forwarding to Jim who is on PTO (until the all hands?). If it's urgent, please ping me on IRC.
Blocks: 1363167
Flags: needinfo?(michael.l.comella) → needinfo?(nchen)
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Flags: needinfo?(nchen)
We may get an Activity that is not the main Fennec Activity in
IntentHelper.openUriExternal. In that case the Activity would not be a
FragmentActivity, and we should go through the fallback case. r=me for
trivial patch.
Attachment #8881502 - Flags: review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/119f62fd31af
Support Activities other than main Fennec Activity in openUriExternal; r=me
https://hg.mozilla.org/mozilla-central/rev/119f62fd31af
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Please request Beta approval on this when you get a chance.
status-firefox54: --- → unaffected
status-firefox55: --- → affected
Flags: needinfo?(nchen)
tracking-fennec: ? → +
[triage@0712] + as already fixed.
Comment on attachment 8881502 [details] [diff] [review]
Support Activities other than main Fennec Activity in openUriExternal (v1)

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Possible crash when using Firefox
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small, one-line change that only affects the crashing condition.
[String changes made/needed]: None
Flags: needinfo?(nchen)
Attachment #8881502 - Flags: approval-mozilla-beta?
Comment on attachment 8881502 [details] [diff] [review]
Support Activities other than main Fennec Activity in openUriExternal (v1)

Crash fix, let's land this on beta.
Attachment #8881502 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: