1373913 - TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js | test_delayed_defaultBrowser - [test_delayed_defaultBrowser : 1586] isDefaultBrowser must be of the right type. - "object" == "boolean"

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

First seen Sat Jun 17, 2017, 8:27:05:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=e156549bd91a5036d58a7724dd386e041738cb46

TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js | xpcshell return code: 0
 
TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js | test_delayed_defaultBrowser - [test_delayed_defaultBrowser : 1586] isDefaultBrowser must be of the right type. - "object" == "boolean"

M-C last good: fe809f57bf2287bb937c3422ed03a63740
M-C first bad: bb8eab3c3ac4147848c4c85d628ba72029

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fe809f57bf2287bb937c3422ed03a63740&tochange=bb8eab3c3ac4147848c4c85d628ba72029

Caused by bug 1367029.

Maybe exclude TB here:
https://hg.mozilla.org/mozilla-central/rev/adb51b322ca8#l1.57

TB is not really a "default browser", so this test might not apply to it.

Alessio and Georg, please advise.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1373913-default-browser-thunderbird.patch

Maybe like this.

Comment 2

[Jorg K (CEST = GMT+2)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ebde595ea211669cab4c1a06c4598edccd84cb56

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8878765 [details] [diff] [review]
1373913-default-browser-thunderbird.patch

No, that didn't work, see try, still failing.

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1373913 - Skip the default browser test on Thunderbird.

Review commit: https://reviewboard.mozilla.org/r/150332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150332/

Comment 5

[Alessio Placitelli [:Dexter]]

Hey Jorg, this is due to the changes in bug 1367029. It includes always checking for valid values of isDefaultBrowser, while we were more relaxed before.

This patch skips the test on TB, would you mind checking that it works? If it does, I'll flag Georg for review and land it ASAP.

Comment 6

[Jorg K (CEST = GMT+2)]

Thank you for the quick response, let's see:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1d996a5d1ff9319d286b14720020ed132b0624d2

Comment 7

[Alessio Placitelli [:Dexter]]

(In reply to Jorg K (GMT+2) from comment #6)
> Thank you for the quick response, let's see:
> https://treeherder.mozilla.org/#/jobs?repo=try-comm-
> central&revision=1d996a5d1ff9319d286b14720020ed132b0624d2

Thank you for pushing this to try ;) Looks like the patch is working, I've flagged Georg for review.

Comment 8

[Jorg K (CEST = GMT+2)]

Yes, working, you beat me to checking it. I made a mistake by doing a debug run, opt would have been quicker, but never mind.

Comment 9

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8879028 [details]
Bug 1373913 - Skip the default browser test on Thunderbird.

https://reviewboard.mozilla.org/r/150332/#review155146

rs=me with the below addressed.

::: toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js:1572
(Diff revision 1)
>    data = TelemetryEnvironment.currentEnvironment;
>    Assert.equal(data.settings.searchCohort, "testcohort");
>  });
>  
>  add_task(async function test_delayed_defaultBrowser() {
> +  if (AppConstants.MOZ_APP_NAME == "thunderbird") {

Lets use the `skip_if` parameter for `add_task`.

Comment 10

[Alessio Placitelli [:Dexter]]

Comment on attachment 8879028 [details]
Bug 1373913 - Skip the default browser test on Thunderbird.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150332/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae1a0f735603
Skip the default browser test on Thunderbird. r=gfritzsche

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae1a0f735603