1374184 - Merge MediaDecoder::NotifyDataArrived and NotifyDownloadProgressed

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

The same reason as bug 1373595.

It is confusing to SourceBuffer to call these 2 similar functions in a row. We should combine them and leave NotifyDataArrived() only.

http://searchfox.org/mozilla-central/rev/7cc377ce3f0a569c5c9b362d589705cd4fecc0ac/dom/media/mediasource/SourceBuffer.cpp#450-453

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1374184. P1 - add NotifyDataArrivedInternal() and let ResourceCallback call it.

Review commit: https://reviewboard.mozilla.org/r/150686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150686/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1374184. P2 - merge NotifyDataArrived() and NotifyDownloadProgressed().

We also move NotifyDownloadProgressed() to private
since it won't be called outside MediaDecoder.

Review commit: https://reviewboard.mozilla.org/r/150688/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150688/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1374184. P3 - rename NotifyDownloadProgressed to DownloadProgressed for it is used internally by MediaDecoder and fix the comment.

Review commit: https://reviewboard.mozilla.org/r/150690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150690/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8879377 [details]
Bug 1374184. P1 - add NotifyDataArrivedInternal() and let ResourceCallback call it.

https://reviewboard.mozilla.org/r/150686/#review155412

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8879378 [details]
Bug 1374184. P2 - merge NotifyDataArrived() and NotifyDownloadProgressed().

https://reviewboard.mozilla.org/r/150688/#review155414

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8879379 [details]
Bug 1374184. P3 - rename NotifyDownloadProgressed to DownloadProgressed for it is used internally by MediaDecoder and fix the comment.

https://reviewboard.mozilla.org/r/150690/#review155416

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f999427c1db
P1 - add NotifyDataArrivedInternal() and let ResourceCallback call it. r=gerald
https://hg.mozilla.org/integration/autoland/rev/4d27d17b8fa5
P2 - merge NotifyDataArrived() and NotifyDownloadProgressed(). r=gerald
https://hg.mozilla.org/integration/autoland/rev/51d001d733bb
P3 - rename NotifyDownloadProgressed to DownloadProgressed for it is used internally by MediaDecoder and fix the comment. r=gerald

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f999427c1db
https://hg.mozilla.org/mozilla-central/rev/4d27d17b8fa5
https://hg.mozilla.org/mozilla-central/rev/51d001d733bb