Closed
Bug 137468
Opened 22 years ago
Closed 22 years ago
Mail component bar overlay should not use absolute position numbers
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: bryner, Assigned: bryner)
Details
(Whiteboard: [adt3 RTM])
Attachments
(1 file)
954 bytes,
patch
|
bugs
:
review+
bugzilla
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
[Spun off from bugscape 13692, so those people are cc'd] Currently, the component bar overlay for mail and addressbook (mailTasksOverlay.xul) uses absolute position numbers for the mail, composer, and addressbook icons. This is problematic if someone wishes to insert another icon between these from another overlay. My suggestion is to use insertafter for the composer and addressbook icons.
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
Assignee | ||
Comment 1•22 years ago
|
||
Comment 2•22 years ago
|
||
Comment on attachment 79216 [details] [diff] [review] patch sr=blake
Attachment #79216 -
Flags: superreview+
Comment 3•22 years ago
|
||
Comment on attachment 79216 [details] [diff] [review] patch r=ben@netscape.com
Attachment #79216 -
Flags: review+
Assignee | ||
Comment 4•22 years ago
|
||
requesting adt approval for the branch -- please see bugscape bug 13692 for rationale.
Keywords: adt1.0.0
Assignee | ||
Comment 5•22 years ago
|
||
Marking fixed since this is fixed on the trunk. This is still awaiting approval for branch checkin.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 6•22 years ago
|
||
Will this still work if Mail isn't installed?
Assignee | ||
Comment 7•22 years ago
|
||
Yep, I actually built the installer and XPI's and tested with every combination I could think of, all worked as expected.
Comment 8•22 years ago
|
||
Comment on attachment 79216 [details] [diff] [review] patch a=asa (on behalf of drivers) for checkin to the 1.0 branch
Attachment #79216 -
Flags: approval+
Comment 9•22 years ago
|
||
adt1.0.0-/[ADT3 RTM]. Let's get this on the trunk, and we'll take it for MachV RTM.
Assignee | ||
Comment 10•22 years ago
|
||
It's already there on the trunk.
Comment 11•22 years ago
|
||
Would someone mind explaining why only the addressbook icon was changed to use insertafter, and not the mail icon?
Assignee | ||
Comment 12•22 years ago
|
||
The mail icon could be as well, I think. I was trying to make the least-risk change.
Updated•22 years ago
|
Comment 13•22 years ago
|
||
adt1.0.0-. This is an [adt3 RTM], and we are ramping down for beta right now.
Comment 14•22 years ago
|
||
Verified on trunk. The fix is transparent to end user. Verification is done by viewing the file through LXR: http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/mailTasksOverlay.xul#109
Updated•22 years ago
|
Comment 15•22 years ago
|
||
re-a=chofmann,shaver
Comment 17•22 years ago
|
||
Verified on branch builds at 05-22,23-02 on Win2K, Linux, Mac OSX. On the component bar the icons are shown in the order: N, Mail, Composer, AB.
Keywords: fixed1.0.0 → verified1.0.0
Assignee | ||
Updated•22 years ago
|
Assignee | ||
Comment 18•22 years ago
|
||
Oops, restoring original keyword. This is already checked in.
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•