1375319 - Dispatch fullscreen events to element first rather than dispatch to document directly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Xidorn Quan [:xidorn] UTC+11]

WebKit/Blink currently dispatches fullscreen events to elements, which makes sense, and matches our initial proposal of Fullscreen API [1].

It was not implemented that way probably because the current Gecko approach is easier to implement.

The spec has been changed to dispatch those events to element, and fallback to document in cases at whatwg/fullscreen#90.


[1] https://wiki.mozilla.org/Gecko:FullScreenAPI#fullscreenchange_event

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

This is indeed something we want to do before we unprefix fullscreen.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Xidorn, are you planning to do this soonish?  If not, I can probably steal it.

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

No, I don't currently have a plan, so if you want to work on this, go ahead. Thanks!

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

I'm going to take this as Chrome is going to ship unprefixed Fullscreen API, and I think we should try shipping that as soon as possible as well.

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1375319 part 1 - Make DispatchTrustedEvent able to dispatch composed event and have fullscreen events composed. r=smaug

Depends on D5394

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1375319 part 2 - Use a global const for element to fullscreen in file_fullscreen-api test. r=smaug

Depends on D5414

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1375319 part 3 - Try dispatching fullscreen events to element first rather than document. r=smaug

Some steps in file_fullscreen-api.html are adjusted in order to test
the behavior that the event is correctly dispatched to the document
when element is disconnected.

Depends on D5415

Comment 8

[Xidorn Quan [:xidorn] UTC+11]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6eb5e77e0abce1d6c91b3f74668489a247bcc76d

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9007749 [details]
Bug 1375319 part 1 - Make DispatchTrustedEvent able to dispatch composed event and have fullscreen events composed. r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9007750 [details]
Bug 1375319 part 2 - Use a global const for element to fullscreen in file_fullscreen-api test. r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9007751 [details]
Bug 1375319 part 3 - Try dispatching fullscreen events to element first rather than document. r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ad49dc53686
part 1 - Make DispatchTrustedEvent able to dispatch composed event and have fullscreen events composed. r=smaug
https://hg.mozilla.org/integration/autoland/rev/8a57ee2c6b31
part 2 - Use a global const for element to fullscreen in file_fullscreen-api test. r=smaug
https://hg.mozilla.org/integration/autoland/rev/f11d81a58cde
part 3 - Try dispatching fullscreen events to element first rather than document. r=smaug

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1ad49dc53686
https://hg.mozilla.org/mozilla-central/rev/8a57ee2c6b31
https://hg.mozilla.org/mozilla-central/rev/f11d81a58cde

Comment 14

[Eric Shepherd [:sheppy]]

Added to Firefox 64 for developers.