1375383 - stylo: change to -moz-binding doesn't trigger frame reconstruction

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

Specifically, dom/xbl/test/test_bug790265.xhtml is failing in Stylo but passing in Gecko. It seems the computed value of -moz-binding in this case is correct. It is not clear to me what leads to this failure.

Comment 1

[Darkspirit]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #0)
> dom/xbl/test/test_bug790265.xhtml

bug 790265 (quoted testcase) sounds a bit similar to bug 1375969 ("dynamic change handling in XBL") for me as amateur.
Maybe this bug has become a duplicate of bug 1375969 ? Please just ignore this comment if it's unrelated.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

It could be. We will see when we try to run mochitests the next time I guess.

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

This test still doesn't pass. So the issue here seems to be that CSS frame constructor isn't triggered for this change.

Looking at the code, I don't have idea immediately why this happens...

heycam, any idea?

Comment 4

[Cameron McCormack (:heycam)]

I guess the issue here is that the element is display:none, so we don't bother computing damage for the element, and instead fall back to the path that checks if display values has changed etc.  I'm not sure what the semantics of XBL bindings applied to display:none elements is, but I guess from this test that we at least need them to apply to roots of display:none subtrees.  (I'm not sure how we would ensure we load bindings applied to elements within display:none subtrees.)

Comment 5

[Cameron McCormack (:heycam)]

Some testing shows that Gecko doesn't apply bindings to elements within display:none subtrees, so handling it just on the display:none root should be fine.

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Oh, I didn't notice that it is a display:none...

Comment 7

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=703cc4f4e0827b37dd5c63d91011d36ec870ab60

Comment 8

[Cameron McCormack (:heycam)]

Attachment: Bug 1375383 - style: Ensure we generate a ReconstructFrame hint when -moz-binding changes on a display:none root.

Review commit: https://reviewboard.mozilla.org/r/160802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160802/

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8889726 [details]
Bug 1375383 - style: Ensure we generate a ReconstructFrame hint when -moz-binding changes on a display:none root.

https://reviewboard.mozilla.org/r/160802/#review166092

Kinda sad we need this special case... r=me

Comment 10

[Cameron McCormack (:heycam)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #9)
> Kinda sad we need this special case... r=me

XBL ¯\_(ツ)_/¯

Comment 11

[Cameron McCormack (:heycam)]

Attachment: Servo PR

Comment 12

[Cameron McCormack (:heycam)]

Merged.