Closed
Bug 1375759
Opened 7 years ago
Closed 7 years ago
Fix Advanced Layers browser-chrome crash in SetCompositorAnimations
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
Details
Attachments
(1 file)
|
7.53 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
Example: https://treeherder.mozilla.org/#/jobs?repo=try&author=danderson@mozilla.com&selectedJob=108802160 Have not been able to reproduce locally, but I have a loan machine from another bug.
|
Assignee | |
Comment 1•7 years ago
|
||
Whoops. I forgot some layers boilerplate. I added a MOZ_RELEASE_ASSERT that we don't change layer manager types, but theoretically it could happen? I'm not sure how to handle that yet.
Attachment #8881113 -
Flags: review?(matt.woodrow)
|
||
Updated•7 years ago
|
Attachment #8881113 -
Flags: review?(matt.woodrow) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9db369ba372c Implement LayerMLGPU::SetLayerManager. (bug 1375759, r=mattwoodrow)
Backout by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/7da6c9907099 Backed out changeset 9db369ba372c for unused mComputedDrawRegion. r=backout
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/71125aa849d3 Implement LayerMLGPU::SetLayerManager. (bug 1375759, r=mattwoodrow)
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/71125aa849d3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•