1375944 - stylo: missing labels on add an attachment on BMO

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Ludovic Hirlimann [:Usul]]

Attachment: Screenshot-2017-6-23 Create New Attachment for Bug #1375902.png

with Stylo enabled go to a bugzilla issue click the add an attachment link.
Pages load but doesn't display any text as per the attached screenshot.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I'm pretty sure this is a very recent regression. I've used a stylo build for filing bugs not long ago.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

My build was with the patches on bug 1371130, so something between that an nightly is what have regressed it.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

So I haven't been able to repro with current autoland tip so far (without webrender). This is on a debug build (waiting on a release build as we speak).

The page has:

#header {
    color: transparent;
}

and also a similar selector for a, #header a, etc... with the correct color.

However, they're all on the same stylesheet, and the |a| selector will make us restyle the whole document when the stylesheet is loaded, so I'm discarding bug 1357583 as the culprit... Also, the other sections that appear blank don't seem to have any selector like that.

The Ctrl + F5 vs. F5 issue may highlight a stylesheet reusing bug or something like that?

Does it repro without WR?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

(The WR question is because the screenshot at bug 1375935 mentioned it, btw)

Comment 6

[Darkspirit]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #4)
> Does it repro without WR?

Yes, bug 1375935 is reproducible with webrender+webrendest and without them.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

(In reply to Darkspirit from comment #6)
> (In reply to Emilio Cobos Álvarez [:emilio] from comment #4)
> > Does it repro without WR?
> 
> Yes, bug 1375935 is reproducible with webrender+webrendest and without them.

Actually, this could also be a dupe of bug 1375674 too. My build did have those patches, and the symptom could be related. Marking a dependency since that should be close to landing, before continuing to investigate.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Before speculatively doing that... May I ask which addons do you have? I've tried to repro it in a bunch of ways on a current profile and I just couldn't :(

Comment 9

[Emilio Cobos Álvarez (:emilio)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #8)
> Before speculatively doing that... May I ask which addons do you have? I've
> tried to repro it in a bunch of ways on a current profile and I just
> couldn't :(

With a clean profile, I mean...

Comment 10

[Darkspirit]

Attachment: 2017-06-24_18-44-09.mp4

(In reply to Emilio Cobos Álvarez [:emilio] from comment #8)
> Before speculatively doing that... May I ask which addons do you have? I've tried to repro it in a bunch of ways on a current profile and I just couldn't :(

As bug 1375935 is a duplicate of this, I upload this proof here: A fresh profile on Debian testing x64.

Comment 11

[Ludovic Hirlimann [:Usul]]

Grammalecte
Mastodon share
Pinboard
test pilot
wayback machine
vidyo replay download
Youtube high definition

it broke for me on flipping the pref and flipping it back.

I also have a theme -> frisian flag

Comment 12

[Astley Chen (inactive)]

Attachment: text-no-show.png

Unfortunately, I can't file stylo bugs via stylo nightly as this bug seriously affects readability of BMO.

Comment 13

[Bobby Holley (:bholley)]

(In reply to Astley Chen [:astley] (UTC-7) from comment #12)
> Created attachment 8881339 [details]
> text-no-show.png
> 
> Unfortunately, I can't file stylo bugs via stylo nightly as this bug
> seriously affects readability of BMO.

Do you have any addons installed? If not, you and Emilio should sit down tomorrow morning and figure out how to reproduce it.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #13)
> (In reply to Astley Chen [:astley] (UTC-7) from comment #12)
> > Created attachment 8881339 [details]
> > text-no-show.png
> > 
> > Unfortunately, I can't file stylo bugs via stylo nightly as this bug
> > seriously affects readability of BMO.
> 
> Do you have any addons installed? If not, you and Emilio should sit down
> tomorrow morning and figure out how to reproduce it.

Ok, so we debugged this today, and I can't repro it because I had the Fira Sans font installed locally, so it's probably a font-face issue.

Comment 15

[Bobby Holley (:bholley)]

Xidorn is going to investigate this.

Comment 16

[Xidorn Quan [:xidorn] UTC+11]

Attachment: simplified testcase from bugzilla page

This is the simplified testcase. The first load of this page may behave normally, but later refresh would trigger this issue.

It happens whenever there is a reference of ex unit anywhere in the page.

Comment 17

[Xidorn Quan [:xidorn] UTC+11]

Invoking IncrementGeneration() in ContinueLoad fixes this issue. Not sure whether this is the correct fix, though. I need to analyze a bit further to figure out a real fix.

Comment 18

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1375944 - Increment font set generation when font-face is synchronously loaded in post-traversal.

Review commit: https://reviewboard.mozilla.org/r/152920/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152920/

Comment 19

[Mozilla Autoland]

hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
searching for changes
remote: waiting for lock on working directory of /repo/hg/mozilla/try held by process '29479' on host 'hgssh4.dmz.scl3.mozilla.com'
remote: got lock after 5 seconds
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 3 changesets with 5 changes to 6 files (+1 heads)
remote: autoland push detected
remote: recorded push in pushlog
remote: 
remote: View your changes here:
remote:   https://hg.mozilla.org/try/rev/467684eafd512d89c5b8ee04e39cd94925e7982e
remote:   https://hg.mozilla.org/try/rev/c89590c461db463b9da14c753ebb1624db8eae7c
remote:   https://hg.mozilla.org/try/rev/b77e1e16ea3bf97a6556415eb5f4206b3661c688
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=b77e1e16ea3bf97a6556415eb5f4206b3661c688
remote: recorded changegroup in replication log in 0.133s
remote: ** unknown exception encountered, please report by visiting
remote: ** https://mercurial-scm.org/wiki/BugTracker
remote: ** Python 2.7.5 (default, Nov  6 2016, 00:28:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]
remote: ** Mercurial Distributed SCM (version 4.1.2)
remote: ** Extensions loaded: blackbox, clonebundles, obsolescencehacks, pushlog, serverlog, readonly, vcsreplicator
remote: Traceback (most recent call last):
remote:   File "/var/hg/venv_pash/bin/hg", line 45, in <module>
remote:     mercurial.dispatch.run()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 63, in run
remote:     sys.exit((dispatch(request(pycompat.sysargv[1:])) or 0) & 255)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 129, in dispatch
remote:     ret = _runcatch(req)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 219, in _runcatch
remote:     return callcatch(ui, _runcatchfunc)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 227, in callcatch
remote:     return scmutil.callcatch(ui, func)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/scmutil.py", line 152, in callcatch
remote:     return func()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 208, in _runcatchfunc
remote:     return _dispatch(req)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 811, in _dispatch
remote:     cmdpats, cmdoptions)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 563, in runcommand
remote:     ret = _runcommand(ui, options, cmd, d)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 819, in _runcommand
remote:     return cmdfunc()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 808, in <lambda>
remote:     d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/util.py", line 1051, in check
remote:     return func(*args, **kwargs)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/commands.py", line 5824, in serve
remote:     s.serve_forever()
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 320, in serve_forever
remote:     return super(sshserverwrapped, self).serve_forever()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/sshserver.py", line 104, in serve_forever
remote:     while self.serve_one():
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 351, in serve_one
remote:     return super(sshserverwrapped, self).serve_one()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/sshserver.py", line 122, in serve_one
remote:     rsp = wireproto.dispatch(self.repo, self, cmd)
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 343, in dispatch
remote:     return origdispatch(repo, proto, cmd)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/extensions.py", line 223, in closure
remote:     return func(*(args + a), **kw)
remote:   File "/var/hg/version-control-tools/pylib/vcsreplicator/vcsreplicator/hgext.py", line 359, in wireprotodispatch
remote:     return orig(repo, proto, command)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/wireproto.py", line 569, in dispatch
remote:     return func(repo, proto, *args)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/wireproto.py", line 982, in unbundle
remote:     proto._client())
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/exchange.py", line 1771, in unbundle
remote:     lockandtr[2].close()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/transaction.py", line 43, in _active
remote:     return func(self, *args, **kwds)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/transaction.py", line 490, in close
remote:     self._postclosecallback[cat](self)
remote:   File "/var/hg/version-control-tools/hgext/pushlog/__init__.py", line 239, in onpostclose
remote:     conn.commit()
remote: sqlite3.OperationalError: database is locked
abort: stream ended unexpectedly (got 0 bytes, expected 4)

Comment 20

[Cameron McCormack (:heycam)]

Comment on attachment 8881858 [details]
Bug 1375944 - Increment font set generation when font-face is synchronously loaded in post-traversal.

https://reviewboard.mozilla.org/r/152920/#review158112

::: gfx/thebes/gfxUserFontSet.cpp:463
(Diff revision 1)
>  gfxUserFontEntry::ContinueLoad()
>  {
>      MOZ_ASSERT(mUserFontLoadState == STATUS_LOAD_PENDING);
>      MOZ_ASSERT(mSrcList[mSrcIndex].mSourceType == gfxFontFaceSrc::eSourceType_URL);
>  
> +    SetLoadState(STATUS_LOADING);

Hmm, I wonder if not doing this was causing bugs in the FontFaceSet API...

Comment 21

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8881858 [details]
Bug 1375944 - Increment font set generation when font-face is synchronously loaded in post-traversal.

https://reviewboard.mozilla.org/r/152920/#review158112

> Hmm, I wonder if not doing this was causing bugs in the FontFaceSet API...

Not sure. I just want to be able to check the load state after calling `DoLoadNextSrc`.

Comment 22

[Xidorn Quan [:xidorn] UTC+11]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff601e70bcafeeab12c8ad2ef7be7ffa8ddfec86

Looks like there is an unexpected pass in reftest :)

Comment 23

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8881858 [details]
Bug 1375944 - Increment font set generation when font-face is synchronously loaded in post-traversal.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152920/diff/1-2/

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21f6ba7bb580
Increment font set generation when font-face is synchronously loaded in post-traversal. r=heycam

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21f6ba7bb580

Comment 26

[Darkspirit]

(In reply to Darkspirit from comment #10)
> 2017-06-24_18-44-09.mp4

Can't reproduce anymore.
Seems to be fixed in today's 20170630100234 @ Debian Testing x64 (Radeon RX480).