1375988 - Empty notification received on Firefox Beta

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The very first notification I received was empty. No title, no contents. Screenshot attached.

It is unclear if this was a fxaccount:* notification or if this was the result of me sending myself a tab from Desktop.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Firefox Beta 4218 via Internal TestFlight

Comment 2

[Ryan Kelly [:rfkelly]]

Quick drive-by, but...IIRC FxA will send a push notification with no payload when you verify your account or confirm a signin, might be a good candidate to look at for debugging this.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Why no payload? Is there no way to identify this notification?

Are you saying we can we assume that a zero length message is the sign in confirmation?

We cannot ignore this message, and I don't think we have a good string for it. Should this be the "Tap to begin" notification maybe?

Comment 4

[Ryan Kelly [:rfkelly]]

> Are you saying we can we assume that a zero length message is the sign in confirmation?

Yes.  For historical reasons (we added this one before payloads were properly supported end-to-end) the "you are now verified" event is signaled by a push notification with empty body.  It will mean either "your email address was successfully verified" or "your login session was successfully confirmed", depending on whether you did a signup or a signin.  But in either case what it means is basically "you're now ready to start syncing".

I expect we could disable this message on the server though, in the same way we intend to disable the other unsupported messages.

Comment 5

[Ryan Kelly [:rfkelly]]

On desktop, this event surfaces as a "sync will begin momentarily" notification.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I think it is a good idea to disable this one on the server for now. We can address it when we have strings for this notification.

Is it possible to give this notification a proper payload so that we can see the difference between signup or signin?

Cc to :vladikoff to request a Github issue for this

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Moving this to 8.1

Comment 8

[Vlad Filippov (:vladikoff)]

(In reply to Stefan Arentz [:st3fan] from comment #7)
> Moving this to 8.1

Can we remove `Importance:	P1	blocker` from this? (If this was moved for later release)

> Is it possible to give this notification a proper payload so that we can see the difference between signup or signin?


We can try! I filed an issue here: https://github.com/mozilla/fxa-auth-server/issues/1976

Comment 9

[Catalin Suciu [:csuciu]]

I receiving an empty notification intermittently when following this steps:

1. Same FxA signed in on: - Nightly 56.0a1 (2017-07-09) 
                          - iPad Mini (10.3.1)
                          - iPhone 6 Plus (10.3.2)
2. Send a few tabs from desktop to iPad
3. Send a few tabs from desktop to iPhone
4. Select a tab on desktop and "Send to All Devices"

Result: Once in a while, when sending to all devices, I'm getting an extra empty push notification on iPad.

This doesn't seem to happen on iPhone.

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The above is with Beta 4467

Comment 11

[Justin D'Arcangelo [:justindarc]]

Taking this to investigate.

Comment 13

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Moving this to 9.0. Also, this bug needs to turn into one that is more concrete/actionable.

Comment 14

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3279

Comment 16

[Vijay Budhram]

Comment on attachment 8917449 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3279

LGTM

Comment 17

[James Hugman [:jhugman] [@jhugman]]

Merged into master. 
Uplifted to v10.x  64680b2