1376007 - Receive and handle FxAccount push notification – account verified

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, enhancement, P1)

Description

[James Hugman [:jhugman] [@jhugman]]

There doesn't seem to be any specific message for account verified.

https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/FxAccountPushHandler.java#38 allows for an empty payload.

Bug 1274150 on the server, may also be related.

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3037

Comment 2

[James Hugman [:jhugman] [@jhugman]]

This is blocked on being FxA not being able to send an accountVerified message to the device. 

Once we see that, then we can perhaps duplicate it with fxa.core.Client.

Comment 3

[Vijay Budhram]

Last week worked with James and this is what we found/updated:

 * Deployed a new version of http://ios-push2.dev.lcip.org, that always sends an `accountVerify` message.
 * Changed `case accountVerified = "accountVerify"`, line 224 in FxAPushMessageHandler

Tested with an updated PyFxA script to simulate sending the message

```
from getpass import getpass
from fxa.core import Client

c = Client("https://ios-push2.dev.lcip.org/auth/v1")
s = c.login(email, password)

try:
    s.apiclient.post("/account/devices/notify", json={
      "to": "all",
      "endpointAction": "accountVerify",
      "payload": {}
    }, auth=s._auth)
finally:
    s.destroy_session()
```

I noticed that if the account is unverified, the push messaged received is nil. Manually verifying the account and re-running script correctly shows an `accountVerify` push message. Is it possible that there is something in the iOS client that doesn't correctly register push messaging until after an account has been confirmed?

Comment 4

[James Hugman [:jhugman] [@jhugman]]

(In reply to Vijay Budhram from comment #3)
> I noticed that if the account is unverified, the push messaged received is
> nil. Manually verifying the account and re-running script correctly shows an
> `accountVerify` push message. Is it possible that there is something in the
> iOS client that doesn't correctly register push messaging until after an
> account has been confirmed?
This may be the same bug as Bug 1382561. Will add that comment there.

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8896500 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3037

This patch has got really small now!

Comment 6

[James Hugman [:jhugman] [@jhugman]]

Merged into master.

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplift when https://github.com/mozilla/fxa-auth-server/pull/2108 has been resolved.