Closed
Bug 1376126
Opened 7 years ago
Closed 7 years ago
CycleCollectedJSRuntime::RemoveJSHolder does unnecessary hashtable lookups
Categories
(Core :: XPCOM, enhancement, P2)
Core
XPCOM
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: perf)
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
I'm assuming that the Trace call can't change the mJSHolders hashtable. We iterate mJSHolders in some places and call Trace so it seems it should hold. http://searchfox.org/mozilla-central/rev/77b256dc98efb93f1d118db456f442a09bba77c2/xpcom/base/CycleCollectedJSRuntime.cpp#780 http://searchfox.org/mozilla-central/rev/77b256dc98efb93f1d118db456f442a09bba77c2/xpcom/base/CycleCollectedJSRuntime.cpp#1044 Looks green on Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a729c616fe2523e055d6f0f4358e4aed005d79ed
Attachment #8881064 -
Flags: review?(nfroyd)
Attachment #8881064 -
Flags: feedback?(continuation)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8881064 [details] [diff] [review] Use Lookup() entry instead of Get+Remove in CycleCollectedJSRuntime::RemoveJSHolder to avoid unnecessary hashtable lookups Review of attachment 8881064 [details] [diff] [review]: ----------------------------------------------------------------- For avoidance of doubt: please wait for mccr8's feedback before landing. Thanks!
Attachment #8881064 -
Flags: review?(nfroyd) → review+
|
||
Updated•7 years ago
|
Attachment #8881064 -
Flags: feedback?(continuation) → feedback+
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4692d0721273 Use Lookup() entry instead of Get+Remove in CycleCollectedJSRuntime::RemoveJSHolder to avoid unnecessary hashtable lookups. r=froydnj
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4692d0721273
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•2 years ago
|
Performance Impact: --- → ?
Whiteboard: [qf]
You need to log in
before you can comment on or make changes to this bug.
Description
•